Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 551011: Changed the signature of Application::Draw to accept elapsed time. It will be... (Closed)

Created:
10 years, 11 months ago by alokp
Modified:
9 years, 6 months ago
Reviewers:
greggman
CC:
chromium-reviews_googlegroups.com, apatrick_chromium
Visibility:
Public.

Description

Changed the signature of Application::Draw to accept elapsed time. It will be used to update key frames or making the application frame-rate independent. However I think there is some bug somewhere. It takes an eternity for the cube in simple-vertex-shader demo to start rotating. Even when the cube starts rotatiing the performance is quite choppy. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=36156

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -7 lines) Patch
M gpu/demos/app_framework/application.h View 1 3 chunks +11 lines, -1 line 0 comments Download
M gpu/demos/app_framework/application.cc View 1 1 chunk +9 lines, -1 line 0 comments Download
M gpu/demos/hello_triangle/main.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M gpu/demos/simple_vertex_shader/main.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
alokp
10 years, 11 months ago (2010-01-13 17:56:11 UTC) #1
greggman
LGTM http://codereview.chromium.org/551011/diff/1/4 File gpu/demos/app_framework/application.cc (right): http://codereview.chromium.org/551011/diff/1/4#newcode85 gpu/demos/app_framework/application.cc:85: Draw(elapsed_msec); I'd suggest you pass elapsed_seconds here instead ...
10 years, 11 months ago (2010-01-13 18:32:51 UTC) #2
alokp
10 years, 11 months ago (2010-01-13 18:48:20 UTC) #3
Will you look into why it is taking such a long time for the cube to start
rotating?

http://codereview.chromium.org/551011/diff/1/4
File gpu/demos/app_framework/application.cc (right):

http://codereview.chromium.org/551011/diff/1/4#newcode85
gpu/demos/app_framework/application.cc:85: Draw(elapsed_msec);
changed to seconds

Powered by Google App Engine
This is Rietveld 408576698