Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: gclient_scm.py

Issue 551002: Update docs for git usage (Closed)
Patch Set: Created 10 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gclient.py ('k') | scm.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gclient_scm.py
diff --git a/gclient_scm.py b/gclient_scm.py
index 9aa0f0609ec8997286cabdc4fc1a3ce18327ca4f..45d0de0067161ed16445e11aaf361dec8d9f83d6 100644
--- a/gclient_scm.py
+++ b/gclient_scm.py
@@ -17,7 +17,7 @@ import gclient_utils
class DiffFilterer(object):
"""Simple class which tracks which file is being diffed and
replaces instances of its file name in the original and
- working copy lines of the svn diff output."""
+ working copy lines of the svn/git diff output."""
index_string = "Index: "
original_prefix = "--- "
working_prefix = "+++ "
@@ -55,7 +55,6 @@ class DiffFilterer(object):
# Factory Method for SCM wrapper creation
def CreateSCM(url=None, root_dir=None, relpath=None, scm_name='svn'):
- # TODO(maruel): Deduce the SCM from the url.
scm_map = {
'svn' : SVNWrapper,
'git' : GitWrapper,
@@ -78,9 +77,8 @@ def CreateSCM(url=None, root_dir=None, relpath=None, scm_name='svn'):
class SCMWrapper(object):
"""Add necessary glue between all the supported SCM.
- This is the abstraction layer to bind to different SCM. Since currently only
- subversion is supported, a lot of subersionism remains. This can be sorted out
- once another SCM is supported."""
+ This is the abstraction layer to bind to different SCM.
+ """
def __init__(self, url=None, root_dir=None, relpath=None,
scm_name='svn'):
self.scm_name = scm_name
@@ -128,6 +126,11 @@ class GitWrapper(SCMWrapper, scm.GIT):
self._Run(['diff', merge_base], redirect_stdout=False)
def export(self, options, args, file_list):
+ """Export a clean directory tree into the given path.
+
+ Exports into the specified directory, creating the path if it does
+ already exist.
+ """
__pychecker__ = 'unusednames=file_list,options'
assert len(args) == 1
export_path = os.path.abspath(os.path.join(args[0], self.relpath))
@@ -138,7 +141,11 @@ class GitWrapper(SCMWrapper, scm.GIT):
def pack(self, options, args, file_list):
"""Generates a patch file which can be applied to the root of the
- repository."""
+ repository.
+
+ The patch file is generated from a diff of the merge base of HEAD and
+ its upstream branch.
+ """
__pychecker__ = 'unusednames=file_list,options'
path = os.path.join(self._root_dir, self.relpath)
merge_base = self._Run(['merge-base', 'HEAD', 'origin'])
@@ -318,6 +325,7 @@ class SVNWrapper(SCMWrapper, scm.SVN):
self.Run(command, os.path.join(self._root_dir, self.relpath))
def export(self, options, args, file_list):
+ """Export a clean directory tree into the given path."""
__pychecker__ = 'unusednames=file_list,options'
assert len(args) == 1
export_path = os.path.abspath(os.path.join(args[0], self.relpath))
@@ -342,7 +350,7 @@ class SVNWrapper(SCMWrapper, scm.SVN):
self.RunAndFilterOutput(command, path, False, False, filterer.Filter)
def update(self, options, args, file_list):
- """Runs SCM to update or transparently checkout the working copy.
+ """Runs svn to update or transparently checkout the working copy.
All updated files will be appended to file_list.
« no previous file with comments | « gclient.py ('k') | scm.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698