Issue 5510003: Fix RGB->YUV conversion: input is BGR instead of RGB.

Issue 5510003: Fix RGB->YUV conversion: input is BGR instead of RGB. (Closed)

Created:
10 years ago by Sergey Ulanov

Modified:
9 years, 7 months ago

Reviewers:
garykac, Alpha Left Google

CC:
chromium-reviews, Sergey Ulanov, dmac, awong, garykac

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fix RGB->YUV conversion: input is BGR instead of RGB. TEST=Colors are not screwed up BUG=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68388

Patch Set 2 : - #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
	M	remoting/base/encoder_vp8.cc	View	1	1 chunk	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

garykac

http://codereview.chromium.org/5510003/diff/1/remoting/base/encoder_vp8.cc File remoting/base/encoder_vp8.cc (right): http://codereview.chromium.org/5510003/diff/1/remoting/base/encoder_vp8.cc#newcode130 remoting/base/encoder_vp8.cc:130: y_out[j] = clip_byte(((pixel[1] * 66 + pixel[1] * 129 ...

10 years ago (2010-12-06 21:08:38 UTC) #2

garykac

On 2010/12/06 21:08:38, garykac wrote: > http://codereview.chromium.org/5510003/diff/1/remoting/base/encoder_vp8.cc > File remoting/base/encoder_vp8.cc (right): > > http://codereview.chromium.org/5510003/diff/1/remoting/base/encoder_vp8.cc#newcode130 > ...

10 years ago (2010-12-06 21:10:17 UTC) #3

Sergey Ulanov

10 years ago (2010-12-06 21:12:11 UTC) #4

Alpha Left Google

10 years ago (2010-12-06 21:48:59 UTC) #5

On 2010/12/06 21:12:11, sergeyu wrote:
> http://codereview.chromium.org/5510003/diff/1/remoting/base/encoder_vp8.cc
> File remoting/base/encoder_vp8.cc (right):
> 
>
http://codereview.chromium.org/5510003/diff/1/remoting/base/encoder_vp8.cc#ne...
> remoting/base/encoder_vp8.cc:130: y_out[j] = clip_byte(((pixel[1] * 66 +
> pixel[1] * 129 +
> On 2010/12/06 21:08:38, garykac wrote:
> > This should be 2.
> 
> Done.

LGTM.

Expand Messages | Collapse Messages