Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 5507001: base: Remove stub scoped_variant_win.h file. (Closed)

Created:
10 years ago by tfarina
Modified:
9 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews, amit, ben+cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

base: Remove stub scoped_variant_win.h file. Fix the callers and add base::win in the call sites. BUG=None TEST=trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68251

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -44 lines) Patch
D base/scoped_variant_win.h View 1 chunk +0 lines, -9 lines 0 comments Download
M base/win/scoped_variant.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/history_publisher_win.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M chrome_frame/test/chrome_frame_ui_test_utils.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome_frame/test/chrome_frame_ui_test_utils.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M chrome_frame/test/ie_event_sink.cc View 8 chunks +10 lines, -11 lines 0 comments Download
M chrome_frame/test/mock_ie_event_sink_test.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M chrome_frame/test/ui_test.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome_frame/utils.cc View 3 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tfarina
Please, take a look.
10 years ago (2010-12-02 12:57:29 UTC) #1
brettw
10 years ago (2010-12-02 16:44:32 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698