Support valgrinding layout tests.

tools/valgrind/valgrind_analyze.py

 #!/usr/bin/python
 # Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # valgrind_analyze.py
 
 ''' Given a valgrind XML file, parses errors and uniques them.'''
 
 import logging
 import optparse
 import os
 import sys
+import time
 from xml.dom.minidom import parse
 
 # These are functions (using C++ mangled names) that we look for in stack
 # traces. We don't show stack frames while pretty printing when they are below
 # any of the following:
 _TOP_OF_STACK_POINTS = [
   # Don't show our testing framework.
   "testing::Test::Run()",
   # Also don't show the internals of libc/pthread.
   "start_thread"
@@ skipping 158 matching lines @@
     '''Reads in a set of files.
 
     Args:
       source_dir: Path to top of source tree for this build
       files: A list of filenames.
       show_all_leaks: whether to show even less important leaks
     '''
 
     self._errors = set()
     for file in files:
+      # Wait up to a minute for valgrind to finish writing.
+      f = open(file, "r")
+      ntries = 60
+      for tries in range(0, ntries):
+        f.seek(0)
+        if sum((1 for line in f if '</valgrindoutput>' in line)) > 0:
+          break
+        time.sleep(1)
+      f.close()
+      if tries == ntries-1:

[Erik does not do reviews, 2009/03/30 16:22:48]

space around operator

+        logging.error("valgrind never finished?")
       raw_errors = parse(file).getElementsByTagName("error")
       for raw_error in raw_errors:
         # Ignore "possible" leaks for now by default.
-        if (show_all_leaks or getTextOf(raw_error, "kind") != "Leak_PossiblyLost"):
+        if (show_all_leaks or
+            getTextOf(raw_error, "kind") != "Leak_PossiblyLost"):
           self._errors.add(ValgrindError(source_dir, raw_error))
 
   def Report(self):
     if self._errors:
       logging.error("FAIL! There were %s errors: " % len(self._errors))
 
       for error in self._errors:
         logging.error(error)
 
       return -1
@@ skipping 14 matching lines @@
     parser.error("no filename specified")
   filenames = args
 
   analyzer = ValgrindAnalyze(options.source_dir, filenames)
   retcode = analyzer.Report()
 
   sys.exit(retcode)
 
 if __name__ == "__main__":
   _main()