Issue 55030: Run dsymutil before valgrind (Mac)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 55030: Run dsymutil before valgrind (Mac) (Closed)

Created:
11 years, 9 months ago by Mark Mentovai

Modified:
9 years, 7 months ago

Reviewers:
TVL, dank, Nirnimesh

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Run dsymutil before valgrind (Mac) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12693

Patch Set 4 : '' #

Total comments: 1

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -1 line)			Patch
	M	build/mac/strip_save_dsym	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	tools/valgrind/valgrind_test.py	View	1 2 3	4 chunks	+63 lines, -0 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

TVL

lg http://codereview.chromium.org/55030/diff/1004/1005 File tools/valgrind/valgrind_test.py (right): http://codereview.chromium.org/55030/diff/1004/1005#newcode304 Line 304: os.rename(saved_test_command, test_command) do you want an exception ...

11 years, 9 months ago (2009-03-27 20:04:31 UTC) #3

LGTM

Expand Messages | Collapse Messages

Issue 55030: Run dsymutil before valgrind (Mac) (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Messages