Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Issue 55011: Optionally send script sources in 'scripts' command response (Closed)

Created:
11 years, 9 months ago by yurys
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

When devtools window is opening it requests all scripts parsed by the moment. Currently 'scripts' response contains only first 80 chars of the scripts sources. I added an argument to the protocol that allows to include full source text into the response. Committed: http://code.google.com/p/v8/source/detail?r=1638

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M src/debug-delay.js View 1 3 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
yurys
11 years, 9 months ago (2009-03-27 14:25:11 UTC) #1
Søren Thygesen Gjesse
11 years, 9 months ago (2009-03-27 14:43:32 UTC) #2
LGTM

http://codereview.chromium.org/55011/diff/1/2
File src/debug-delay.js (right):

http://codereview.chromium.org/55011/diff/1/2#newcode1658
Line 1658: includeSource = !!request.arguments.includeSource;
To match the rest of this file I would write it as:

if (!IS_UNDEFINED(request.arguments.includeSource)) {
  includeSource = %ToBoolean(request.arguments.includeSource);
}

Powered by Google App Engine
This is Rietveld 408576698