Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 5501001: Update prebuilt.py to set permissions correctly on created Packages file. (Closed)

Created:
10 years ago by davidjames
Modified:
9 years, 4 months ago
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa, Eric Shienbrood
Visibility:
Public.

Description

Update prebuilt.py to set permissions correctly on created Packages file. Since the local Packages file is a temporary file, other users won't have permissions to read it. rsync copies those permissions over to the remote server. To ensure remote server has the right permissions, we need to use chmod a+r on either the local file or the remote file. In this case, I chose to run rsync on the remote file. TEST=rsync -av --chmod=a+r foo bar and verify permissions are added to bar. BUG=chromium-os:5311 Change-Id: Iee4c8df00b36b9f9434546603195ea1906b289f1 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=a8ae0bc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M prebuilt.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
davidjames
10 years ago (2010-12-01 21:34:06 UTC) #1
sosa
LGTM
10 years ago (2010-12-01 21:42:14 UTC) #2
diandersAtChromium
10 years ago (2010-12-01 21:42:38 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698