Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(732)

Unified Diff: src/objects.cc

Issue 55007: Mark some of the places we leave V8 via callbacks as transitions to... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/log.cc ('k') | src/stub-cache.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.cc
===================================================================
--- src/objects.cc (revision 1629)
+++ src/objects.cc (working copy)
@@ -201,7 +201,7 @@
v8::Handle<v8::Value> result;
{
// Leaving JavaScript.
- VMState state(OTHER);
+ VMState state(EXTERNAL);
result = call_fun(v8::Utils::ToLocal(key), info);
}
RETURN_IF_SCHEDULED_EXCEPTION();
@@ -1423,7 +1423,7 @@
v8::Handle<v8::Value> result;
{
// Leaving JavaScript.
- VMState state(OTHER);
+ VMState state(EXTERNAL);
Handle<Object> value_unhole(value->IsTheHole() ?
Heap::undefined_value() :
value);
@@ -1490,7 +1490,7 @@
v8::Utils::ToLocal(holder_handle));
{
// Leaving JavaScript.
- VMState state(OTHER);
+ VMState state(EXTERNAL);
call_fun(v8::Utils::ToLocal(key),
v8::Utils::ToLocal(value_handle),
info);
@@ -1892,7 +1892,7 @@
v8::Handle<v8::Boolean> result;
{
// Leaving JavaScript.
- VMState state(OTHER);
+ VMState state(EXTERNAL);
result = query(v8::Utils::ToLocal(name_handle), info);
}
if (!result.IsEmpty()) {
@@ -1907,7 +1907,7 @@
v8::Handle<v8::Value> result;
{
// Leaving JavaScript.
- VMState state(OTHER);
+ VMState state(EXTERNAL);
result = getter(v8::Utils::ToLocal(name_handle), info);
}
if (!result.IsEmpty()) return NONE;
@@ -2156,7 +2156,7 @@
v8::Handle<v8::Boolean> result;
{
// Leaving JavaScript.
- VMState state(OTHER);
+ VMState state(EXTERNAL);
result = deleter(v8::Utils::ToLocal(name_handle), info);
}
RETURN_IF_SCHEDULED_EXCEPTION();
@@ -2207,7 +2207,7 @@
v8::Handle<v8::Boolean> result;
{
// Leaving JavaScript.
- VMState state(OTHER);
+ VMState state(EXTERNAL);
result = deleter(index, info);
}
RETURN_IF_SCHEDULED_EXCEPTION();
@@ -5086,7 +5086,7 @@
v8::Handle<v8::Boolean> result;
{
// Leaving JavaScript.
- VMState state(OTHER);
+ VMState state(EXTERNAL);
result = query(index, info);
}
if (!result.IsEmpty()) return result->IsTrue();
@@ -5097,7 +5097,7 @@
v8::Handle<v8::Value> result;
{
// Leaving JavaScript.
- VMState state(OTHER);
+ VMState state(EXTERNAL);
result = getter(index, info);
}
if (!result.IsEmpty()) return !result->IsUndefined();
@@ -5247,7 +5247,7 @@
v8::Handle<v8::Value> result;
{
// Leaving JavaScript.
- VMState state(OTHER);
+ VMState state(EXTERNAL);
result = setter(index, v8::Utils::ToLocal(value_handle), info);
}
RETURN_IF_SCHEDULED_EXCEPTION();
@@ -5474,7 +5474,7 @@
v8::Handle<v8::Value> result;
{
// Leaving JavaScript.
- VMState state(OTHER);
+ VMState state(EXTERNAL);
result = getter(index, info);
}
RETURN_IF_SCHEDULED_EXCEPTION();
@@ -5713,7 +5713,7 @@
v8::Handle<v8::Value> result;
{
// Leaving JavaScript.
- VMState state(OTHER);
+ VMState state(EXTERNAL);
result = getter(v8::Utils::ToLocal(name_handle), info);
}
RETURN_IF_SCHEDULED_EXCEPTION();
« no previous file with comments | « src/log.cc ('k') | src/stub-cache.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698