Fix issue 541 and some refactoring of the top-level compiler.

Fix issue 541 and some refactoring of the top-level compiler.

* Refactor VisitProperty to use the platform-specific methods for emitting the IC calls.
* Refactor recording of source positions in the top-level compiler.
* Correct the recorded source positions for assignments and property loads.
* Fix bug on x64 where source positions were not recorded before a calling a call-IC.
* Correct some inconsistencies between IA-32 and X64 top-level code generator.

We now pass all regression tests with 
--always-fast-compiler.


Committed: http://code.google.com/p/v8/source/detail?r=3612

[Kevin Millikin (Chromium), 2010-01-15 05:46:58]

We should avoid calling FastCodeGenerator::Apply on expression contexts that
don't appear in the AST.

Otherwise, LGTM.

http://codereview.chromium.org/550043/diff/1/6
File src/arm/fast-codegen-arm.cc (right):

http://codereview.chromium.org/550043/diff/1/6#newcode1386
src/arm/fast-codegen-arm.cc:1386: Apply(Expression::kValue, r0);
Just use __push(r0) here.

http://codereview.chromium.org/550043/diff/1/5
File src/fast-codegen.cc (right):

http://codereview.chromium.org/550043/diff/1/5#newcode683
src/fast-codegen.cc:683: Apply(Expression::kValue, result_register());
Use __ push(result_register()).

http://codereview.chromium.org/550043/diff/1/5#newcode687
src/fast-codegen.cc:687: Apply(Expression::kValue, result_register());
And here.

http://codereview.chromium.org/550043/diff/1/3
File src/ia32/fast-codegen-ia32.cc (right):

http://codereview.chromium.org/550043/diff/1/3#newcode1351
src/ia32/fast-codegen-ia32.cc:1351: Apply(Expression::kValue, eax);
__ push(eax).

http://codereview.chromium.org/550043/diff/1/4
File src/x64/fast-codegen-x64.cc (right):

http://codereview.chromium.org/550043/diff/1/4#newcode1371
src/x64/fast-codegen-x64.cc:1371: Apply(Expression::kValue, rax);
__ push(rax).

[fschneider, 2010-01-15 11:59:40]

http://codereview.chromium.org/550043/diff/1/6
File src/arm/fast-codegen-arm.cc (right):

http://codereview.chromium.org/550043/diff/1/6#newcode1386
src/arm/fast-codegen-arm.cc:1386: Apply(Expression::kValue, r0);
On 2010/01/15 05:46:58, Kevin Millikin wrote:
> Just use __push(r0) here.

Done.

http://codereview.chromium.org/550043/diff/1/5
File src/fast-codegen.cc (right):

http://codereview.chromium.org/550043/diff/1/5#newcode683
src/fast-codegen.cc:683: Apply(Expression::kValue, result_register());
On 2010/01/15 05:46:58, Kevin Millikin wrote:
> Use __ push(result_register()).

Done.

http://codereview.chromium.org/550043/diff/1/5#newcode687
src/fast-codegen.cc:687: Apply(Expression::kValue, result_register());
On 2010/01/15 05:46:58, Kevin Millikin wrote:
> And here.

Done.

http://codereview.chromium.org/550043/diff/1/3
File src/ia32/fast-codegen-ia32.cc (right):

http://codereview.chromium.org/550043/diff/1/3#newcode1351
src/ia32/fast-codegen-ia32.cc:1351: Apply(Expression::kValue, eax);
On 2010/01/15 05:46:58, Kevin Millikin wrote:
> __ push(eax).

Done.

http://codereview.chromium.org/550043/diff/1/4
File src/x64/fast-codegen-x64.cc (right):

http://codereview.chromium.org/550043/diff/1/4#newcode1371
src/x64/fast-codegen-x64.cc:1371: Apply(Expression::kValue, rax);
On 2010/01/15 05:46:58, Kevin Millikin wrote:
> __ push(rax).

Done.