deps/third_party/valgrind/scripts/vbug205541.patch - Issue 550036: svn copy tools/valgrind/{*.patch,build-*.sh} deps/third_party/valgrind/script...

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: deps/third_party/valgrind/scripts/vbug205541.patch

Issue 550036: svn copy tools/valgrind/{*.patch,build-*.sh} deps/third_party/valgrind/script... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/

Patch Set: '' Created 10 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

Property Changes:

Added: svn:mergeinfo
Merged /branches/chrome_webkit_merge_branch/tools/valgrind/vbug205541.patch:r69-2775

« no previous file with comments | « deps/third_party/valgrind/scripts/redzone.patch ('k') | deps/third_party/valgrind/scripts/vbug210481.patch » ('j') | no next file with comments »

OLD	NEW
1 # See https://bugs.kde.org/show_bug.cgi?id=205541#c1	1 # See https://bugs.kde.org/show_bug.cgi?id=205541#c1

2 Index: memcheck/mc_main.c	2 Index: memcheck/mc_main.c

3 ===================================================================	3 ===================================================================

4 --- memcheck/mc_main.c (revision 10877)	4 --- memcheck/mc_main.c (revision 10877)

5 +++ memcheck/mc_main.c (working copy)	5 +++ memcheck/mc_main.c (working copy)

6 @@ -3708,7 +3708,14 @@	6 @@ -3708,7 +3708,14 @@

7 if (rr \|\| ww \|\| xx)	7 if (rr \|\| ww \|\| xx)

8 MC_(make_mem_defined)(a, len);	8 MC_(make_mem_defined)(a, len);

9 else	9 else

10 - MC_(make_mem_noaccess)(a, len);	10 - MC_(make_mem_noaccess)(a, len);

11 + MC_(make_mem_defined)(a, len);	11 + MC_(make_mem_defined)(a, len);

12 + /* State after mmap(,,PROT_NONE,,,) should match	12 + /* State after mmap(,,PROT_NONE,,,) should match

13 + * state after mprotect(,,PROT_NONE): the operating system	13 + * state after mprotect(,,PROT_NONE): the operating system

14 + * will trap any access, but any subsequent mprotect(,,PROT_R\|W\|X)	14 + * will trap any access, but any subsequent mprotect(,,PROT_R\|W\|X)

15 + * will re-instate the previous V bits [in this case, all valid].	15 + * will re-instate the previous V bits [in this case, all valid].

16 + * See comment in mc_pre_clo_init() re:	16 + * See comment in mc_pre_clo_init() re:

17 + * VG_(track_change_mem_mprotect) ( NULL );	17 + * VG_(track_change_mem_mprotect) ( NULL );

18 + */	18 + */

19 }	19 }

20	20

21 static	21 static

OLD	NEW