Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 550010: Cleanup the handling of control flow in the toplevel code generator.... (Closed)

Created:
10 years, 11 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Cleanup the handling of control flow in the toplevel code generator. Do abstract the setting and restoring of 'argument' state into a function that takes arguments. Do not set the argument state in the code generator unless it represents arguments to a recursive call to Visit. Committed: http://code.google.com/p/v8/source/detail?r=3594

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -249 lines) Patch
M src/arm/fast-codegen-arm.cc View 7 chunks +42 lines, -66 lines 0 comments Download
M src/fast-codegen.h View 1 chunk +13 lines, -0 lines 0 comments Download
M src/fast-codegen.cc View 5 chunks +20 lines, -57 lines 0 comments Download
M src/ia32/fast-codegen-ia32.cc View 6 chunks +42 lines, -66 lines 0 comments Download
M src/x64/fast-codegen-x64.cc View 6 chunks +36 lines, -60 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Kevin Millikin (Chromium)
Lasse and/or Bill, do you have time to take a quick look at this?
10 years, 11 months ago (2010-01-12 09:00:18 UTC) #1
Kevin Millikin (Chromium)
Florian, do you have time to take a look at this?
10 years, 11 months ago (2010-01-12 16:13:21 UTC) #2
fschneider
10 years, 11 months ago (2010-01-12 18:09:39 UTC) #3
LGTM!

Powered by Google App Engine
This is Rietveld 408576698