Eliminate the dependency on kernel pseudo-files when running unit tests

Makefile

Index: Makefile
diff --git a/Makefile b/Makefile
index 2066cdc085192a44498ddca7bb149107b6745538..1680da2116b3f4a2e9a910073c59c16926bb5dac 100644
--- a/Makefile
+++ b/Makefile
@@ -8,7 +8,12 @@
 # OPT_CFLAGS is here to allow adding options for manual, host-side
 # builds.
 OPT_CFLAGS =
-CFLAGS += -Wall -Werror -fPIC -fno-exceptions $(OPT_CFLAGS)
+COMMON_CFLAGS += -Wall -Werror -fPIC -fno-exceptions $(OPT_CFLAGS)
+
+tests: COMMON_CFLAGS += -DCONFIG_UNIT_TEST

[kmixter1, 2010/12/06 04:23:52]

This is a new syntax to me, assuming you know it works and doesn't mess up if
you do make all tests.

[jrbarnette, 2010/12/06 17:47:46]

Mmmm...  If you say 'make' or 'make all', or other invocations that build
without -DCONFIG_UNIT_TEST, and then say 'make tests', bootstat.o won't
get rebuilt with the changed define, and the build will fail with link errors.

If you say 'make clean' in between, it works fine.

Is building, then rebuilding with different options (without requiring
'make clean') a use case that should be important?

[kmixter1, 2010/12/06 18:22:36]

I was mostly commenting on the fact that the CCFLAGS would be set to having test
flags for even the 'make all' part of the build, but you're correctly pointing
out that the objects themselves are shared and built differently in the two
kinds of builds.

This is your call, but I usually prefer to make the object not have -D's for
test code, just include the test code in production build (particularly if it's
not user visible) as it makes me feel more confidence that there are fewer
differences between test and production code.  It's no more elegant than having
special compilation for tests, but it's easier creating/using a mock interface.

+
+CFLAGS += $(COMMON_CFLAGS)
+CXXFLAGS += $(COMMON_CFLAGS)
 
 LIB_OBJS = bootstat_log.o