Issue 549213: Add UI to TestShell to enable/disable images, plugins, and scripts....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 549213: Add UI to TestShell to enable/disable images, plugins, and scripts.... (Closed)

Created:
10 years, 10 months ago by darin (slow to review)

Modified:
9 years, 7 months ago

Reviewers:
Peter Kasting

CC:
chromium-reviews, darin (slow to review), dpranke+watch_chromium.org, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Add UI to TestShell to enable/disable images, plugins, and scripts. R=pkasting Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=37557

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -2 lines)			Patch
M	webkit/tools/test_shell/resource.h	View		2 chunks	+4 lines, -1 line	0 comments	Download
M	webkit/tools/test_shell/resources/test_shell.rc	View		1 chunk	+6 lines, -1 line	0 comments	Download
M	webkit/tools/test_shell/test_shell.h	View		2 chunks	+13 lines, -0 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell_win.cc	View	1	1 chunk	+21 lines, -0 lines	0 comments	Download
M	webkit/tools/test_shell/test_webview_delegate.h	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	webkit/tools/test_shell/test_webview_delegate.cc	View		2 chunks	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Peter Kasting

10 years, 10 months ago (2010-01-29 22:33:14 UTC) #2

LGTM

http://codereview.chromium.org/549213/diff/1/6
File webkit/tools/test_shell/test_shell_win.cc (right):

http://codereview.chromium.org/549213/diff/1/6#newcode591
webkit/tools/test_shell/test_shell_win.cc:591: bool checked =
Nit: Call this was_checked or negate it right here

Expand Messages | Collapse Messages