Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: chrome/browser/views/find_bar_host_browsertest.cc

Issue 549168: Fix remaining flakiness in FindMoveIfObscuring browser test. ... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 10 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/data/find_in_page/move_if_obscuring.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/views/find_bar_host_browsertest.cc
===================================================================
--- chrome/browser/views/find_bar_host_browsertest.cc (revision 37168)
+++ chrome/browser/views/find_bar_host_browsertest.cc (working copy)
@@ -592,9 +592,9 @@
// We should not have reached the end.
ASSERT_GT(kMoveIterations, index);
- // Search backwards once to get the Find box to move back.
- EXPECT_EQ(kMoveIterations, FindInPageWchar(tab, L"Chromium",
- kBack, kIgnoreCase, &ordinal));
+ // Search for something guaranteed not to be obscured by the Find box.
+ EXPECT_EQ(1, FindInPageWchar(tab, L"Done",
+ kFwd, kIgnoreCase, &ordinal));
// Check the position.
EXPECT_TRUE(GetFindBarWindowInfo(&position, &fully_visible));
EXPECT_TRUE(fully_visible);
« no previous file with comments | « no previous file | chrome/test/data/find_in_page/move_if_obscuring.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698