Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 549160: Add options to install-build-deps.sh to enable unattended mode.... (Closed)

Created:
10 years, 11 months ago by dank
Modified:
9 years, 7 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews
Visibility:
Public.

Description

Add options to install-build-deps.sh to enable unattended mode. BUG=30328 TEST=run with unattended options, verify no prompt Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=37120

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -23 lines) Patch
M build/install-build-deps.sh View 4 chunks +67 lines, -23 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
dank
How's this look?
10 years, 11 months ago (2010-01-26 17:58:35 UTC) #1
M-A Ruel
I really like the solution, lgtm http://codereview.chromium.org/549160/diff/1/2 File build/install-build-deps.sh (right): http://codereview.chromium.org/549160/diff/1/2#newcode303 build/install-build-deps.sh:303: echo "Installing 32bit ...
10 years, 11 months ago (2010-01-26 18:15:41 UTC) #2
dank
10 years, 11 months ago (2010-01-26 18:18:37 UTC) #3
Fixed, commited, thanks.

Powered by Google App Engine
This is Rietveld 408576698