Issue 549147: Load HeapNumbers directly into floating-point registers in BinaryOpSlowCase.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 549147: Load HeapNumbers directly into floating-point registers in BinaryOpSlowCase. (Closed)

Created:
10 years, 11 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Load HeapNumbers directly into floating-point registers in BinaryOpSlowCase. Committed: http://code.google.com/p/v8/source/detail?r=3703

Patch Set 2 : '' #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -28 lines)			Patch
	M	src/arm/codegen-arm.cc	View	1	8 chunks	+50 lines, -28 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

LGTM! http://codereview.chromium.org/549147/diff/1/2 File src/arm/codegen-arm.cc (right): http://codereview.chromium.org/549147/diff/1/2#newcode5276 src/arm/codegen-arm.cc:5276: if (CpuFeatures::IsSupported(VFP3) && Token::MOD != operation) { Since ...

10 years, 11 months ago (2010-01-26 09:05:25 UTC) #2

William Hesse

10 years, 11 months ago (2010-01-26 09:25:14 UTC) #3

http://codereview.chromium.org/549147/diff/1/2
File src/arm/codegen-arm.cc (right):

http://codereview.chromium.org/549147/diff/1/2#newcode5276
src/arm/codegen-arm.cc:5276: if (CpuFeatures::IsSupported(VFP3) && Token::MOD !=
operation) {
On 2010/01/26 09:05:26, Erik Corry wrote:
> Since this 'if' is used several times I think it would express the intent
> clearer to have a bool variable with an explanatory name.  eg.
> float_values_in_vfp_regs.

Done.

http://codereview.chromium.org/549147/diff/1/2#newcode5426
src/arm/codegen-arm.cc:5426: // Convert smi in r1 to double in d6
On 2010/01/26 09:05:26, Erik Corry wrote:
> Missing full stop.

Done.

Expand Messages | Collapse Messages

Issue 549147: Load HeapNumbers directly into floating-point registers in BinaryOpSlowCase. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages