Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Side by Side Diff: chrome/renderer/render_view.cc

Issue 549140: If a page is navigated within the same render process, the active notificatio... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 10 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/renderer/notification_provider.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/renderer/render_view.h" 5 #include "chrome/renderer/render_view.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 789 matching lines...) Expand 10 before | Expand all | Expand 10 after
800 return true; 800 return true;
801 } 801 }
802 802
803 void RenderView::OnNavigate(const ViewMsg_Navigate_Params& params) { 803 void RenderView::OnNavigate(const ViewMsg_Navigate_Params& params) {
804 if (!webview()) 804 if (!webview())
805 return; 805 return;
806 806
807 if (devtools_agent_.get()) 807 if (devtools_agent_.get())
808 devtools_agent_->OnNavigate(); 808 devtools_agent_->OnNavigate();
809 809
810 if (notification_provider_.get())
811 notification_provider_->OnNavigate();
812
810 child_process_logging::SetActiveURL(params.url); 813 child_process_logging::SetActiveURL(params.url);
811 814
812 AboutHandler::MaybeHandle(params.url); 815 AboutHandler::MaybeHandle(params.url);
813 816
814 bool is_reload = (params.navigation_type == ViewMsg_Navigate_Params::RELOAD); 817 bool is_reload = (params.navigation_type == ViewMsg_Navigate_Params::RELOAD);
815 818
816 WebFrame* main_frame = webview()->mainFrame(); 819 WebFrame* main_frame = webview()->mainFrame();
817 if (is_reload && main_frame->currentHistoryItem().isNull()) { 820 if (is_reload && main_frame->currentHistoryItem().isNull()) {
818 // We cannot reload if we do not have any history state. This happens, for 821 // We cannot reload if we do not have any history state. This happens, for
819 // example, when recovering from a crash. Our workaround here is a bit of 822 // example, when recovering from a crash. Our workaround here is a bit of
(...skipping 3208 matching lines...) Expand 10 before | Expand all | Expand 10 after
4028 new PluginMsg_SignalModalDialogEvent(host_window_)); 4031 new PluginMsg_SignalModalDialogEvent(host_window_));
4029 4032
4030 message->EnableMessagePumping(); // Runs a nested message loop. 4033 message->EnableMessagePumping(); // Runs a nested message loop.
4031 bool rv = Send(message); 4034 bool rv = Send(message);
4032 4035
4033 PluginChannelHost::Broadcast( 4036 PluginChannelHost::Broadcast(
4034 new PluginMsg_ResetModalDialogEvent(host_window_)); 4037 new PluginMsg_ResetModalDialogEvent(host_window_));
4035 4038
4036 return rv; 4039 return rv;
4037 } 4040 }
OLDNEW
« no previous file with comments | « chrome/renderer/notification_provider.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698