Issue 549140: If a page is navigated within the same render process, the active notificatio...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 549140: If a page is navigated within the same render process, the active notificatio... (Closed)

Created:
10 years, 11 months ago by John Gregg

Modified:
9 years ago

Reviewers:
Andrew T Wilson (Slow)

CC:
chromium-reviews, brettw+cc_chromium.org, darin (slow to review), jam

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

If a page is navigated within the same render process, the active notifications need to go out of scope so we don't try to fire events on them back to the original page. BUG=32862 TEST=reload page then close notification Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=37019

Patch Set 1 #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -3 lines)			Patch
M	chrome/common/desktop_notifications/active_notification_tracker.h	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/common/desktop_notifications/active_notification_tracker.cc	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	chrome/renderer/notification_provider.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/renderer/notification_provider.cc	View	2 chunks	+7 lines, -2 lines	0 comments	Download
M	chrome/renderer/render_view.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Andrew T Wilson (Slow)

10 years, 11 months ago (2010-01-23 02:17:50 UTC) #2

On 2010/01/23 01:59:13, John Gregg wrote:
> 
LGTM mainly because I'd like to see this bug fixed ASAP, but please follow this
up with a CL containing a test for this case.

Expand Messages | Collapse Messages