Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Side by Side Diff: src/x64/ic-x64.cc

Issue 549132: Bring a fix for v8 bug 589 and Chromium bug 27967 to 1.3.... (Closed) Base URL: http://v8.googlecode.com/svn/branches/1.3/
Patch Set: Created 10 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/version.cc ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2009 the V8 project authors. All rights reserved. 1 // Copyright 2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 255 matching lines...) Expand 10 before | Expand all | Expand 10 after
266 // Check that the object isn't a smi. 266 // Check that the object isn't a smi.
267 __ JumpIfSmi(rcx, &slow); 267 __ JumpIfSmi(rcx, &slow);
268 268
269 // Check that the object is some kind of JS object EXCEPT JS Value type. 269 // Check that the object is some kind of JS object EXCEPT JS Value type.
270 // In the case that the object is a value-wrapper object, 270 // In the case that the object is a value-wrapper object,
271 // we enter the runtime system to make sure that indexing 271 // we enter the runtime system to make sure that indexing
272 // into string objects work as intended. 272 // into string objects work as intended.
273 ASSERT(JS_OBJECT_TYPE > JS_VALUE_TYPE); 273 ASSERT(JS_OBJECT_TYPE > JS_VALUE_TYPE);
274 __ CmpObjectType(rcx, JS_OBJECT_TYPE, rdx); 274 __ CmpObjectType(rcx, JS_OBJECT_TYPE, rdx);
275 __ j(below, &slow); 275 __ j(below, &slow);
276 // Check that the receiver does not require access checks. We need 276
277 // to check this explicitly since this generic stub does not perform 277 // Check bit field.
278 // map checks. The map is already in rdx.
279 __ testb(FieldOperand(rdx, Map::kBitFieldOffset), 278 __ testb(FieldOperand(rdx, Map::kBitFieldOffset),
280 Immediate(1 << Map::kIsAccessCheckNeeded)); 279 Immediate(kSlowCaseBitFieldMask));
281 __ j(not_zero, &slow); 280 __ j(not_zero, &slow);
282 281
283 // Check that the key is a smi. 282 // Check that the key is a smi.
284 __ JumpIfNotSmi(rax, &check_string); 283 __ JumpIfNotSmi(rax, &check_string);
285 __ SmiToInteger32(rax, rax); 284 __ SmiToInteger32(rax, rax);
286 // Get the elements array of the object. 285 // Get the elements array of the object.
287 __ bind(&index_int); 286 __ bind(&index_int);
288 __ movq(rcx, FieldOperand(rcx, JSObject::kElementsOffset)); 287 __ movq(rcx, FieldOperand(rcx, JSObject::kElementsOffset));
289 // Check that the object is in fast mode (not dictionary). 288 // Check that the object is in fast mode (not dictionary).
290 __ CompareRoot(FieldOperand(rcx, HeapObject::kMapOffset), 289 __ CompareRoot(FieldOperand(rcx, HeapObject::kMapOffset),
(...skipping 1034 matching lines...) Expand 10 before | Expand all | Expand 10 after
1325 1324
1326 // Cache miss: Jump to runtime. 1325 // Cache miss: Jump to runtime.
1327 Generate(masm, ExternalReference(IC_Utility(kStoreIC_Miss))); 1326 Generate(masm, ExternalReference(IC_Utility(kStoreIC_Miss)));
1328 } 1327 }
1329 1328
1330 1329
1331 #undef __ 1330 #undef __
1332 1331
1333 1332
1334 } } // namespace v8::internal 1333 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/version.cc ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698