Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Side by Side Diff: src/ia32/ic-ia32.cc

Issue 549132: Bring a fix for v8 bug 589 and Chromium bug 27967 to 1.3.... (Closed) Base URL: http://v8.googlecode.com/svn/branches/1.3/
Patch Set: Created 10 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/ic-arm.cc ('k') | src/ic.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 228 matching lines...) Expand 10 before | Expand all | Expand 10 after
239 // Load name and receiver. 239 // Load name and receiver.
240 __ mov(eax, Operand(esp, kPointerSize)); 240 __ mov(eax, Operand(esp, kPointerSize));
241 __ mov(ecx, Operand(esp, 2 * kPointerSize)); 241 __ mov(ecx, Operand(esp, 2 * kPointerSize));
242 242
243 // Check that the object isn't a smi. 243 // Check that the object isn't a smi.
244 __ test(ecx, Immediate(kSmiTagMask)); 244 __ test(ecx, Immediate(kSmiTagMask));
245 __ j(zero, &slow, not_taken); 245 __ j(zero, &slow, not_taken);
246 246
247 // Get the map of the receiver. 247 // Get the map of the receiver.
248 __ mov(edx, FieldOperand(ecx, HeapObject::kMapOffset)); 248 __ mov(edx, FieldOperand(ecx, HeapObject::kMapOffset));
249 // Check that the receiver does not require access checks. We need 249
250 // to check this explicitly since this generic stub does not perform 250 // Check bit field.
251 // map checks.
252 __ movzx_b(ebx, FieldOperand(edx, Map::kBitFieldOffset)); 251 __ movzx_b(ebx, FieldOperand(edx, Map::kBitFieldOffset));
253 __ test(ebx, Immediate(1 << Map::kIsAccessCheckNeeded)); 252 __ test(ebx, Immediate(kSlowCaseBitFieldMask));
254 __ j(not_zero, &slow, not_taken); 253 __ j(not_zero, &slow, not_taken);
255 // Check that the object is some kind of JS object EXCEPT JS Value type. 254 // Check that the object is some kind of JS object EXCEPT JS Value type.
256 // In the case that the object is a value-wrapper object, 255 // In the case that the object is a value-wrapper object,
257 // we enter the runtime system to make sure that indexing 256 // we enter the runtime system to make sure that indexing
258 // into string objects work as intended. 257 // into string objects work as intended.
259 ASSERT(JS_OBJECT_TYPE > JS_VALUE_TYPE); 258 ASSERT(JS_OBJECT_TYPE > JS_VALUE_TYPE);
260 __ movzx_b(edx, FieldOperand(edx, Map::kInstanceTypeOffset)); 259 __ movzx_b(edx, FieldOperand(edx, Map::kInstanceTypeOffset));
261 __ cmp(edx, JS_OBJECT_TYPE); 260 __ cmp(edx, JS_OBJECT_TYPE);
262 __ j(less, &slow, not_taken); 261 __ j(less, &slow, not_taken);
263 // Check that the key is a smi. 262 // Check that the key is a smi.
(...skipping 1113 matching lines...) Expand 10 before | Expand all | Expand 10 after
1377 1376
1378 // Do tail-call to runtime routine. 1377 // Do tail-call to runtime routine.
1379 __ TailCallRuntime( 1378 __ TailCallRuntime(
1380 ExternalReference(IC_Utility(kSharedStoreIC_ExtendStorage)), 3, 1); 1379 ExternalReference(IC_Utility(kSharedStoreIC_ExtendStorage)), 3, 1);
1381 } 1380 }
1382 1381
1383 #undef __ 1382 #undef __
1384 1383
1385 1384
1386 } } // namespace v8::internal 1385 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/arm/ic-arm.cc ('k') | src/ic.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698