Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 549107: Add --with_dev_pkgs option to build_image.sh to pull in developer debug packages. (Closed)

Created:
10 years, 11 months ago by tedbo
Modified:
10 years, 11 months ago
Reviewers:
sosa
CC:
chromium-os-reviews_googlegroups.com, rtc, kanliu
Visibility:
Public.

Description

Add --with_dev_pkgs option to build_image.sh to pull in developer debug packages. This defaults to TRUE when building an image. This CL moves some developer-only packages from package-list-prod.txt to package-list-debug.txt and adds support for a comma-separated list of package lists to build_image.sh. Actually, I'd like to rename package-list-dev.txt to package-list-build.txt and package-list-debug.txt to package-list-dev.txt but maybe in another CL. Also there is a patch from lool that we should grab some stuff from that can filter the package lists by build architecture. Eventually we will likely add target-specific package lists as well. With this change, build_image.sh --nowith_dev_pkgs will build an image that does not contain niceties such as xterm.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -29 lines) Patch
A src/package_repo/package-list-debug.txt View 1 chunk +26 lines, -0 lines 0 comments Download
M src/package_repo/package-list-prod.txt View 2 chunks +3 lines, -22 lines 0 comments Download
M src/scripts/build_image.sh View 2 chunks +7 lines, -2 lines 0 comments Download
M src/scripts/install_packages.sh View 2 chunks +11 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tedbo
10 years, 11 months ago (2010-01-20 07:31:29 UTC) #1
sosa
10 years, 11 months ago (2010-01-20 08:08:39 UTC) #2
On 2010/01/20 07:31:29, tedbo wrote:
> 

LGTM.  Thanks Ted.

Powered by Google App Engine
This is Rietveld 408576698