Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4939)

Unified Diff: chrome/common/sandbox_mac_unittest_helper.mm

Issue 5491001: Mac: Sandbox GPU process. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: make tests work for now Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/sandbox_mac_unittest_helper.mm
diff --git a/chrome/common/sandbox_mac_unittest_helper.mm b/chrome/common/sandbox_mac_unittest_helper.mm
index 4e885b507bebe5c3dabef877c998e902e3fe2fd9..87b8399950aa613c623518fe0204aeffc37b6ffd 100644
--- a/chrome/common/sandbox_mac_unittest_helper.mm
+++ b/chrome/common/sandbox_mac_unittest_helper.mm
@@ -50,13 +50,20 @@ void AddSandboxTestCase(const char* test_name, MacSandboxTestCase* test_class) {
} // namespace internal
-bool MacSandboxTest:: RunTestInAllSandboxTypes(const char* test_name,
- const char* test_data) {
+bool MacSandboxTest::RunTestInAllSandboxTypes(const char* test_name,
+ const char* test_data) {
// Go through all the sandbox types, and run the test case in each of them
// if one fails, abort.
for(int i = static_cast<int>(Sandbox::SANDBOX_TYPE_FIRST_TYPE);
i < Sandbox::SANDBOX_AFTER_TYPE_LAST_TYPE;
++i) {
+
+ if (i == Sandbox::SANDBOX_TYPE_GPU) {
+ // TODO(thakis): Remove this once the gpu sandbox is more restricted.
+ // http://crbug.com/48607
jeremy 2010/12/02 08:33:56 Could you please add a note to the bug to remove t
+ continue;
+ }
+
if (!RunTestInSandbox(static_cast<Sandbox::SandboxProcessType>(i),
test_name, test_data)) {
LOG(ERROR) << "Sandboxed test (" << test_name << ")" <<

Powered by Google App Engine
This is Rietveld 408576698