Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(808)

Issue 549090: Added pglGetCurrentContext. Make gles2 implementation pointer global variable... (Closed)

Created:
10 years, 11 months ago by apatrick_chromium
Modified:
9 years, 7 months ago
Reviewers:
alokp
CC:
chromium-reviews_googlegroups.com, apatrick_chromium
Visibility:
Public.

Description

Added pglGetCurrentContext. Make gles2 implementation pointer global variable thread local. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=36560

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -20 lines) Patch
M gpu/command_buffer/client/gles2_lib.h View 1 chunk +11 lines, -5 lines 0 comments Download
M gpu/command_buffer/client/gles2_lib.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M gpu/pgl/pgl.h View 1 chunk +17 lines, -1 line 0 comments Download
M gpu/pgl/pgl.cc View 1 3 chunks +7 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
apatrick_chromium
10 years, 11 months ago (2010-01-19 21:05:35 UTC) #1
alokp
LGTM http://codereview.chromium.org/549090/diff/1/5 File gpu/command_buffer/client/gles2_lib.h (right): http://codereview.chromium.org/549090/diff/1/5#newcode12 gpu/command_buffer/client/gles2_lib.h:12: #if defined(_MSC_VER) I have seen this defined at ...
10 years, 11 months ago (2010-01-19 21:15:58 UTC) #2
apatrick_chromium
10 years, 11 months ago (2010-01-19 21:18:13 UTC) #3
http://codereview.chromium.org/549090/diff/1/5
File gpu/command_buffer/client/gles2_lib.h (right):

http://codereview.chromium.org/549090/diff/1/5#newcode12
gpu/command_buffer/client/gles2_lib.h:12: #if defined(_MSC_VER)
I removed it from pgl.cc so its only defined in one place.

http://codereview.chromium.org/549090/diff/1/2
File gpu/pgl/pgl.cc (right):

http://codereview.chromium.org/549090/diff/1/2#newcode147
gpu/pgl/pgl.cc:147: PGLContext pglGetCurrentContext(void) {
On 2010/01/19 21:15:58, alokp wrote:
> this should be defined before pglSwapBuffers in the same order as declared in
> pgl.h

Done.

Powered by Google App Engine
This is Rietveld 408576698