Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(945)

Issue 549083: Add a test to detect if the main disk is a SSD. (Closed)

Created:
10 years, 11 months ago by Tom Wai-Hong Tam
Modified:
9 years, 5 months ago
Reviewers:
petkov, mbligh, ericli
CC:
chromium-os-reviews_googlegroups.com
Visibility:
Public.

Description

Add a test to detect if the main disk is a SSD. It uses "hdparm -I" to check. However, it is not 100% sure if the device doesn't report the rotation rate.

Patch Set 1 #

Patch Set 2 : Setup deps and include this test into pre-compilation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -1 line) Patch
A client/deps/hdparm/common.py View 1 chunk +8 lines, -0 lines 0 comments Download
A client/deps/hdparm/control View 1 chunk +1 line, -0 lines 0 comments Download
A client/deps/hdparm/hdparm.py View 1 chunk +22 lines, -0 lines 0 comments Download
A client/deps/hdparm/hdparm-9.27.tar.gz View Binary file 0 comments Download
M client/site_tests/setup/control View 2 chunks +2 lines, -1 line 0 comments Download
A client/site_tests/storage_SsdDetection/control View 1 chunk +16 lines, -0 lines 0 comments Download
A client/site_tests/storage_SsdDetection/storage_SsdDetection.py View 1 1 chunk +49 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Tom Wai-Hong Tam
10 years, 11 months ago (2010-01-19 11:57:23 UTC) #1
mbligh
Seems fine, assuming ericli's fix precompiles deps as well as tests? If not, might be ...
10 years, 11 months ago (2010-01-19 13:43:08 UTC) #2
petkov
On 2010/01/19 13:43:08, mbligh wrote: > Seems fine, assuming ericli's fix precompiles deps as well ...
10 years, 11 months ago (2010-01-19 17:56:54 UTC) #3
ericli
Yeah, you need a similar code snippet to setup deps. Also please take a look ...
10 years, 11 months ago (2010-01-19 18:06:44 UTC) #4
petkov
10 years, 11 months ago (2010-01-20 18:49:03 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698