Issue 549063: Added cubemap demo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 549063: Added cubemap demo. (Closed)

Created:
10 years, 11 months ago by alokp

Modified:
9 years, 6 months ago

Reviewers:
apatrick, apatrick_chromium

CC:
chromium-reviews_googlegroups.com, apatrick_chromium

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Added cubemap demo. BUG=26099 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=36356

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+141 lines, -50 lines)			Patch
M	gpu/demos/demos.gyp	View	1 chunk	+11 lines, -0 lines	0 comments	Download
A	gpu/demos/simple_texture_cubemap/main.cc	View	1 chunk	+63 lines, -0 lines	2 comments	Download
A	third_party/gles2_book/Chapter_9/Simple_TextureCubemap/Simple_TextureCubemap.h	View	1 chunk	+49 lines, -0 lines	0 comments	Download
M	third_party/gles2_book/Chapter_9/Simple_TextureCubemap/Simple_TextureCubemap.c	View	5 chunks	+7 lines, -50 lines	0 comments	Download
M	third_party/gles2_book/gles2_book.gyp	View	1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

apatrick

10 years, 11 months ago (2010-01-14 22:41:32 UTC) #2

LGTM

http://codereview.chromium.org/549063/diff/2002/2004
File gpu/demos/simple_texture_cubemap/main.cc (right):

http://codereview.chromium.org/549063/diff/2002/2004#newcode19
gpu/demos/simple_texture_cubemap/main.cc:19: virtual void Draw(float);
parameter should have a name

http://codereview.chromium.org/549063/diff/2002/2004#newcode49
gpu/demos/simple_texture_cubemap/main.cc:49: void
SimpleTextureCubemap::Draw(float) {
parameter should have a name

Expand Messages | Collapse Messages