Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 549063: Added cubemap demo. (Closed)

Created:
10 years, 11 months ago by alokp
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com, apatrick_chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -50 lines) Patch
M gpu/demos/demos.gyp View 1 chunk +11 lines, -0 lines 0 comments Download
A gpu/demos/simple_texture_cubemap/main.cc View 1 chunk +63 lines, -0 lines 2 comments Download
A third_party/gles2_book/Chapter_9/Simple_TextureCubemap/Simple_TextureCubemap.h View 1 chunk +49 lines, -0 lines 0 comments Download
M third_party/gles2_book/Chapter_9/Simple_TextureCubemap/Simple_TextureCubemap.c View 5 chunks +7 lines, -50 lines 0 comments Download
M third_party/gles2_book/gles2_book.gyp View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
alokp
10 years, 11 months ago (2010-01-14 22:11:23 UTC) #1
apatrick
10 years, 11 months ago (2010-01-14 22:41:32 UTC) #2
LGTM

http://codereview.chromium.org/549063/diff/2002/2004
File gpu/demos/simple_texture_cubemap/main.cc (right):

http://codereview.chromium.org/549063/diff/2002/2004#newcode19
gpu/demos/simple_texture_cubemap/main.cc:19: virtual void Draw(float);
parameter should have a name

http://codereview.chromium.org/549063/diff/2002/2004#newcode49
gpu/demos/simple_texture_cubemap/main.cc:49: void
SimpleTextureCubemap::Draw(float) {
parameter should have a name

Powered by Google App Engine
This is Rietveld 408576698