Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 549017: Always use our dpkg wrapper when mastering an image. (Closed)

Created:
10 years, 11 months ago by tedbo
Modified:
9 years, 7 months ago
Reviewers:
Bill Richardson
CC:
chromium-os-reviews_googlegroups.com
Visibility:
Public.

Description

Always use our dpkg wrapper when mastering an image. This changes install_packages to always have apt use our dpkg wrapper when building an image. The dpkg_no_scripts.sh has been modified to check if a package's maintainer scripts have been whitelisted. If so, it will install without maintainer scripts. If any relevant maintainer script has not been whitelisted it will fall back to standard dpkg which will process the maintainer scripts. This will allow us to transition to installing packages without maintainer scripts in batches rather than all at once. Once everything is switched over we will have dpkg_no_scripts.sh throw an error if it encounters a package with maintainer scripts that have not been whitelisted. Move postinst stuff from install_packages.sh to actual postinst scripts.

Patch Set 1 #

Patch Set 2 : Whitespace fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+198 lines, -85 lines) Patch
A src/package_scripts/base-files.postinst View 1 chunk +18 lines, -0 lines 0 comments Download
A src/package_scripts/base-passwd.postinst View 1 chunk +12 lines, -0 lines 0 comments Download
A src/package_scripts/libpam-runtime.postinst View 1 chunk +17 lines, -0 lines 0 comments Download
A src/package_scripts/mawk.postinst View 1 chunk +9 lines, -0 lines 0 comments Download
M src/scripts/dpkg_no_scripts.sh View 2 chunks +134 lines, -40 lines 0 comments Download
M src/scripts/install_packages.sh View 1 3 chunks +8 lines, -45 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tedbo
The next step is a script that will help in filling in the whitelist.
10 years, 11 months ago (2010-01-12 01:11:25 UTC) #1
Bill Richardson
10 years, 11 months ago (2010-01-12 01:24:37 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698