Issue 5485001: GYP file cleanup, browser.h speech_input_result.h and popop_blocked_animation.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5485001: GYP file cleanup, browser.h speech_input_result.h and popop_blocked_animation.h (Closed)

Created:
10 years ago by dhollowa

Modified:
9 years, 7 months ago

Reviewers:
Satish, Ben Goodger (Google)

CC:
chromium-reviews, Evan Stade

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

GYP file cleanup, browser.h speech_input_result.h and popop_blocked_animation.h Small corrections to gyp files for missing or moved headers. BUG=none TEST=unit tests and try bots. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67903

Patch Set 1 #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -3 lines)			Patch
M	chrome/chrome_browser.gypi	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	chrome/chrome_common.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	2 chunks	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

use chromium acct.

lgtm (although I don't know why you picked me in particular for this review)

10 years ago (2010-12-01 20:34:20 UTC) #2

dhollowa

On 2010/12/01 20:34:20, estade wrote: > lgtm (although I don't know why you picked me ...

10 years ago (2010-12-01 21:11:21 UTC) #4

LGTM

Expand Messages | Collapse Messages