Issue 548207: Don't store IDR ids in ThemePack files as they change whenever the grd is modified.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 548207: Don't store IDR ids in ThemePack files as they change whenever the grd is modified. (Closed)

Created:
10 years, 10 months ago by Elliot Glaysher

Modified:
9 years, 7 months ago

Reviewers:
Miranda Callahan

CC:
chromium-reviews_googlegroups.com, Paweł Hajdan Jr., ben+cc_chromium.org

Visibility:
Public.

Description

Don't store IDR ids in ThemePack files as they change whenever the grd is modified. Instead, add an association table at the top of browser_theme_pack.cc that maps the JSON string name and IDR# to a stable constant that won't change between releases. The ThemePack version number has been bumped to two, forcing a rebuild. BUG=33416 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=37722

Patch Set 1 #

Patch Set 2 : More tests and cleaner persistant id access #

Total comments: 1

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+257 lines, -78 lines)			Patch
	M	chrome/browser/browser_theme_pack.cc	View	1	13 chunks	+219 lines, -68 lines	1 comment	Download
	M	chrome/browser/browser_theme_pack_unittest.cc	View	1	4 chunks	+38 lines, -10 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Miranda Callahan

10 years, 10 months ago (2010-01-29 23:36:10 UTC) #2

Great, LGTM! -- though with one kinda big spelling nit that will make you glad
for search-and-replace.  ;-)

http://codereview.chromium.org/548207/diff/2001/2002
File chrome/browser/browser_theme_pack.cc (right):

http://codereview.chromium.org/548207/diff/2001/2002#newcode60
chrome/browser/browser_theme_pack.cc:60: // Persistant constants for the main
images that we need. These have the same
spelling nit (everywhere): "persistent".

Expand Messages | Collapse Messages