Issue 5482002: Fix a ui test result since numbers are now doubles

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5482002: Fix a ui test result since numbers are now doubles (Closed)

Created:
10 years ago by tony

Modified:
9 years, 7 months ago

Reviewers:
jam, Paweł Hajdan Jr.

CC:
chromium-reviews, jam, darin-cc_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/webkit/glue/plugins/test

Visibility:
Public.

Description

Fix a ui test and test_shell_tests results since numbers are now doubles (to match Safari). This was done in http://trac.webkit.org/changeset/72974 BUG=64874 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67914

Patch Set 1 #

Patch Set 2 : double #

Patch Set 3 : test_shell_tests #

Total comments: 1

Created: 10 years ago

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -5 lines)
M	chrome/test/ui/npapi_uitest.cc	View	1 chunk	+1 line, -1 line	1 comment
M	webkit/glue/cpp_bound_class_unittest.cc	View	1 chunk	+1 line, -2 lines	0 comments
M	webkit/glue/plugins/test/plugin_windowed_test.cc	View	1 chunk	+2 lines, -2 lines	0 comments

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

10 years ago (2010-12-02 09:17:27 UTC) #3

Drive-by with a nit.

http://codereview.chromium.org/5482002/diff/5001/chrome/test/ui/npapi_uitest.cc
File chrome/test/ui/npapi_uitest.cc (right):

http://codereview.chromium.org/5482002/diff/5001/chrome/test/ui/npapi_uitest....
chrome/test/ui/npapi_uitest.cc:329: // Starting failing during WebKit roll
72952:72986, see http://crbug.com/64874
nit: I think you also want to remove the comment.

Expand Messages | Collapse Messages