Issue 548198: Rewrite CsvParser.parseLine to make it simpler and gain some performance improvement.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 548198: Rewrite CsvParser.parseLine to make it simpler and gain some performance improvement. (Closed)

Created:
10 years, 11 months ago by mnaganov (inactive)

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Visibility:
Public.

Description

Rewrite CsvParser.parseLine to make it simpler and gain some performance improvement. Committed: http://code.google.com/p/v8/source/detail?r=3746

Patch Set 1 #

Total comments: 2

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -37 lines)			Patch
	M	test/mjsunit/tools/csvparser.js	View		1 chunk	+4 lines, -0 lines	0 comments	Download
	M	tools/csvparser.js	View		2 chunks	+22 lines, -37 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

LGTM http://codereview.chromium.org/548198/diff/1/3 File tools/csvparser.js (right): http://codereview.chromium.org/548198/diff/1/3#newcode72 tools/csvparser.js:72: fields.push(field.replace(doubleQuoteRe, '"')); Is this covered by any tests?

10 years, 10 months ago (2010-01-29 13:21:34 UTC) #2

mnaganov (inactive)

10 years, 10 months ago (2010-01-29 13:31:10 UTC) #3

http://codereview.chromium.org/548198/diff/1/3
File tools/csvparser.js (right):

http://codereview.chromium.org/548198/diff/1/3#newcode72
tools/csvparser.js:72: fields.push(field.replace(doubleQuoteRe, '"'));
On 2010/01/29 13:21:34, Søren Gjesse wrote:
> Is this covered by any tests?

You mean double quotes? Lines 53--63 in test/mjsunit/tools/csvparser.js

Expand Messages | Collapse Messages