Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Side by Side Diff: src/x64/stub-cache-x64.cc

Issue 548181: Remove some unneeded restorations of a register in StoreIC. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 10 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/stub-cache-ia32.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2009 the V8 project authors. All rights reserved. 1 // Copyright 2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1375 matching lines...) Expand 10 before | Expand all | Expand 10 after
1386 __ push(rax); // value 1386 __ push(rax); // value
1387 __ push(rbx); // restore return address 1387 __ push(rbx); // restore return address
1388 1388
1389 // Do tail-call to the runtime system. 1389 // Do tail-call to the runtime system.
1390 ExternalReference store_callback_property = 1390 ExternalReference store_callback_property =
1391 ExternalReference(IC_Utility(IC::kStoreCallbackProperty)); 1391 ExternalReference(IC_Utility(IC::kStoreCallbackProperty));
1392 __ TailCallRuntime(store_callback_property, 4, 1); 1392 __ TailCallRuntime(store_callback_property, 4, 1);
1393 1393
1394 // Handle store cache miss. 1394 // Handle store cache miss.
1395 __ bind(&miss); 1395 __ bind(&miss);
1396 __ Move(rcx, Handle<String>(name)); // restore name 1396
William Hesse 2010/01/28 13:51:45 Extra blank line will be removed.
1397 Handle<Code> ic(Builtins::builtin(Builtins::StoreIC_Miss)); 1397 Handle<Code> ic(Builtins::builtin(Builtins::StoreIC_Miss));
1398 __ Jump(ic, RelocInfo::CODE_TARGET); 1398 __ Jump(ic, RelocInfo::CODE_TARGET);
1399 1399
1400 // Return the generated code. 1400 // Return the generated code.
1401 return GetCode(CALLBACKS, name); 1401 return GetCode(CALLBACKS, name);
1402 } 1402 }
1403 1403
1404 1404
1405 Object* StoreStubCompiler::CompileStoreField(JSObject* object, 1405 Object* StoreStubCompiler::CompileStoreField(JSObject* object,
1406 int index, 1406 int index,
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
1473 __ push(rax); // value 1473 __ push(rax); // value
1474 __ push(rbx); // restore return address 1474 __ push(rbx); // restore return address
1475 1475
1476 // Do tail-call to the runtime system. 1476 // Do tail-call to the runtime system.
1477 ExternalReference store_ic_property = 1477 ExternalReference store_ic_property =
1478 ExternalReference(IC_Utility(IC::kStoreInterceptorProperty)); 1478 ExternalReference(IC_Utility(IC::kStoreInterceptorProperty));
1479 __ TailCallRuntime(store_ic_property, 3, 1); 1479 __ TailCallRuntime(store_ic_property, 3, 1);
1480 1480
1481 // Handle store cache miss. 1481 // Handle store cache miss.
1482 __ bind(&miss); 1482 __ bind(&miss);
1483 __ Move(rcx, Handle<String>(name)); // restore name
1484 Handle<Code> ic(Builtins::builtin(Builtins::StoreIC_Miss)); 1483 Handle<Code> ic(Builtins::builtin(Builtins::StoreIC_Miss));
1485 __ Jump(ic, RelocInfo::CODE_TARGET); 1484 __ Jump(ic, RelocInfo::CODE_TARGET);
1486 1485
1487 // Return the generated code. 1486 // Return the generated code.
1488 return GetCode(INTERCEPTOR, name); 1487 return GetCode(INTERCEPTOR, name);
1489 } 1488 }
1490 1489
1491 1490
1492 Object* StoreStubCompiler::CompileStoreGlobal(GlobalObject* object, 1491 Object* StoreStubCompiler::CompileStoreGlobal(GlobalObject* object,
1493 JSGlobalPropertyCell* cell, 1492 JSGlobalPropertyCell* cell,
(...skipping 396 matching lines...) Expand 10 before | Expand all | Expand 10 after
1890 __ Jump(generic_construct_stub, RelocInfo::CODE_TARGET); 1889 __ Jump(generic_construct_stub, RelocInfo::CODE_TARGET);
1891 1890
1892 // Return the generated code. 1891 // Return the generated code.
1893 return GetCode(); 1892 return GetCode();
1894 } 1893 }
1895 1894
1896 1895
1897 #undef __ 1896 #undef __
1898 1897
1899 } } // namespace v8::internal 1898 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/ia32/stub-cache-ia32.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698