Issue 548181: Remove some unneeded restorations of a register in StoreIC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 548181: Remove some unneeded restorations of a register in StoreIC. (Closed)

Created:
10 years, 11 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Kevin Millikin (Chromium), Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Remove some unneeded restorations of a register in StoreIC. Committed: http://code.google.com/p/v8/source/detail?r=3737

Patch Set 1 #

Total comments: 1

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -6 lines)			Patch
M	src/arm/stub-cache-arm.cc	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	src/ia32/stub-cache-ia32.cc	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	src/x64/stub-cache-x64.cc	View	2 chunks	+1 line, -2 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

William Hesse

http://codereview.chromium.org/548181/diff/1/3 File src/x64/stub-cache-x64.cc (right): http://codereview.chromium.org/548181/diff/1/3#newcode1396 src/x64/stub-cache-x64.cc:1396: Extra blank line will be removed.

10 years, 11 months ago (2010-01-28 13:51:45 UTC) #2

LGTM

Expand Messages | Collapse Messages