Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Issue 548137: Don't build packages inside destination directory (Closed)

Created:
10 years, 11 months ago by cjwatson
Modified:
9 years, 7 months ago
Reviewers:
tedbo, Bill Richardson
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Don't build packages inside destination directory chromiumos-build's destination directory shouldn't be a build directory; as advised in chromiumos-build(1), this can cause it to think that failed builds were actually successful. Build downloaded source packages in src/build/ARCHITECTURE/external/ instead. While we're here, rename the configuration file to a more visible name.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
A + src/scripts/chromiumos-build.cfg View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
cjwatson
10 years, 11 months ago (2010-01-25 10:41:41 UTC) #1
Bill Richardson
10 years, 11 months ago (2010-01-25 16:20:22 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698