Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 548135: Mac: Fix %cpu in task manager. (Closed)

Created:
10 years, 11 months ago by Nico
Modified:
9 years, 7 months ago
Reviewers:
Robert Sesek, jeremy
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Mac: Fix %cpu in task manager. I changed %cpu from int to double but left the +0.5 for rounding in. Duh. BUG=32464 TEST=Task Manager %cpu should match Activity Monitor's %cpu. In particular, inactive processes should have 0.0% cpu instead of 0.5%. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=37004

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M base/process_util_mac.mm View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Nico
10 years, 11 months ago (2010-01-25 07:57:23 UTC) #1
jeremy
(not on the reviewer list but still) LGTM
10 years, 11 months ago (2010-01-25 08:46:36 UTC) #2
Robert Sesek
10 years, 11 months ago (2010-01-25 14:15:03 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698