Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Side by Side Diff: chrome/browser/renderer_host/render_widget_host_view_mac.h

Issue 548119: Merge 36790 - Insert diagnostics in an attempt to track down a crash in popup... (Closed) Base URL: svn://svn.chromium.org/chrome/branches/302/src/
Patch Set: Created 10 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/renderer_host/render_widget_host_view_mac.mm » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Property Changes:
Deleted: svn:mergeinfo
Reverse-merged /branches/chrome_webkit_merge_branch/chrome/browser/render_widget_host_hwnd.h:r69-2775
OLDNEW
1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_MAC_H_ 5 #ifndef CHROME_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_MAC_H_
6 #define CHROME_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_MAC_H_ 6 #define CHROME_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_MAC_H_
7 7
8 #import <Cocoa/Cocoa.h> 8 #import <Cocoa/Cocoa.h>
9 9
10 #include "base/scoped_nsobject.h" 10 #include "base/scoped_nsobject.h"
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
108 const std::vector<WebMenuItem>& items); 108 const std::vector<WebMenuItem>& items);
109 virtual gfx::Rect GetWindowRect(); 109 virtual gfx::Rect GetWindowRect();
110 virtual gfx::Rect GetRootWindowRect(); 110 virtual gfx::Rect GetRootWindowRect();
111 virtual void SetActive(bool active); 111 virtual void SetActive(bool active);
112 virtual void SetBackground(const SkBitmap& background); 112 virtual void SetBackground(const SkBitmap& background);
113 113
114 void KillSelf(); 114 void KillSelf();
115 115
116 void set_parent_view(BaseView* parent_view) { parent_view_ = parent_view; } 116 void set_parent_view(BaseView* parent_view) { parent_view_ = parent_view; }
117 117
118 // Used only to diagnose the crash in http://crbug.com/31716
119 // TODO(pamg): Remove when no longer needed.
120 void clear_cocoa_view() { cocoa_view_ = nil; }
121
118 // These member variables should be private, but the associated ObjC class 122 // These member variables should be private, but the associated ObjC class
119 // needs access to them and can't be made a friend. 123 // needs access to them and can't be made a friend.
120 124
121 // The associated Model. Can be NULL if Destroy() is called when 125 // The associated Model. Can be NULL if Destroy() is called when
122 // someone (other than superview) has retained |cocoa_view_|. 126 // someone (other than superview) has retained |cocoa_view_|.
123 RenderWidgetHost* render_widget_host_; 127 RenderWidgetHost* render_widget_host_;
124 128
125 // This is true when we are currently painting and thus should handle extra 129 // This is true when we are currently painting and thus should handle extra
126 // paint requests by expanding the invalid rect rather than actually painting. 130 // paint requests by expanding the invalid rect rather than actually painting.
127 bool about_to_validate_and_paint_; 131 bool about_to_validate_and_paint_;
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
216 // Factory used to safely scope delayed calls to ShutdownHost(). 220 // Factory used to safely scope delayed calls to ShutdownHost().
217 ScopedRunnableMethodFactory<RenderWidgetHostViewMac> shutdown_factory_; 221 ScopedRunnableMethodFactory<RenderWidgetHostViewMac> shutdown_factory_;
218 222
219 // Used for positioning a popup menu. 223 // Used for positioning a popup menu.
220 BaseView* parent_view_; 224 BaseView* parent_view_;
221 225
222 DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostViewMac); 226 DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostViewMac);
223 }; 227 };
224 228
225 #endif // CHROME_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_MAC_H_ 229 #endif // CHROME_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_MAC_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/renderer_host/render_widget_host_view_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698