Build: allow package lists to be filtered by arch.

Build: allow package lists to be filtered by arch.

This is copied from lminier@ in his patch "Rewrite local repository
generation".

[cjwatson, 2010-01-22 11:36:39]

Thanks for this; this will get rid of another of my local hacks ...

http://codereview.chromium.org/548109/diff/1/2
File src/package_repo/package-list-prod.txt (right):

http://codereview.chromium.org/548109/diff/1/2#newcode46
src/package_repo/package-list-prod.txt:46: acpid [i386]
Could you also make chromeos-acpi i386-only for the same reason?

I have flashplugin-installer marked as not-for-armel in my local tree, although
I don't know what the planned Flash story on ARM is.

http://codereview.chromium.org/548109/diff/1/3
File src/scripts/install_packages.sh (right):

http://codereview.chromium.org/548109/diff/1/3#newcode216
src/scripts/install_packages.sh:216: function filter_pkgs {
Is there any reason that local shell style isn't to use the portable
'filter_pkgs () {' syntax, by the way?  We don't seem to gain anything by using
the bashism 'function'.

http://codereview.chromium.org/548109/diff/1/3#newcode238
src/scripts/install_packages.sh:238: done
I'll trust that this works (and it looks right), but it is somewhat obscure. 
Would it be clearer to explicitly iterate over the list of architecture
specifications using 'for' instead?

[adlr, 2010-01-22 20:17:26]

please have another look. thanks.

http://codereview.chromium.org/548109/diff/1/2
File src/package_repo/package-list-prod.txt (right):

http://codereview.chromium.org/548109/diff/1/2#newcode46
src/package_repo/package-list-prod.txt:46: acpid [i386]
On 2010/01/22 11:36:39, cjwatson wrote:
> Could you also make chromeos-acpi i386-only for the same reason?
> 
> I have flashplugin-installer marked as not-for-armel in my local tree,
although
> I don't know what the planned Flash story on ARM is.

Done.

http://codereview.chromium.org/548109/diff/1/3
File src/scripts/install_packages.sh (right):

http://codereview.chromium.org/548109/diff/1/3#newcode216
src/scripts/install_packages.sh:216: function filter_pkgs {
On 2010/01/22 11:36:39, cjwatson wrote:
> Is there any reason that local shell style isn't to use the portable
> 'filter_pkgs () {' syntax, by the way?  We don't seem to gain anything by
using
> the bashism 'function'.

Done.

http://codereview.chromium.org/548109/diff/1/3#newcode238
src/scripts/install_packages.sh:238: done
On 2010/01/22 11:36:39, cjwatson wrote:
> I'll trust that this works (and it looks right), but it is somewhat obscure. 
> Would it be clearer to explicitly iterate over the list of architecture
> specifications using 'for' instead?

I didn't write this code (see CL description), but I did test it. I'd just
assume keep it as-is since it's working.

[tedbo, 2010-01-22 22:52:08]

LGTM

Thanks!