Rewrite make_chroot.sh to use local mirrors directly.

Rewrite make_chroot.sh to use local mirrors directly.

Use our karmic mirror for creating the build chroot, removing the need for
make_local_repo.sh and the repo_list_*.txt files. If a local repo exists
when build_chroot.sh is run it will be used, but it's no longer necessary.

This change does not remove make_local_repo.sh or the repo_list_*.txt files.

[tedbo, 2010-01-20 03:39:57]

Thanks for working on this. I think people are tired of the local repo and
having to rebuild chroots.

Some comments below.

http://codereview.chromium.org/548083/diff/1/3
File src/scripts/common.sh (right):

http://codereview.chromium.org/548083/diff/1/3#newcode82
src/scripts/common.sh:82:
DEFAULT_CHROMEOS_SERVER=${CHROMEOS_SERVER:-"http://build.chromium.org/mirror"}
Why did you define new variables here rather than updating DEFAULT_DEV_SUITE,
DEFAULT_IMG_SUITE, DEFAULT_DEV_MIRROR, DEFAULT_IMG_MIRROR below?

With this change you should be able to get rid of DEFAULT_EXT_*

http://codereview.chromium.org/548083/diff/1/5
File src/scripts/make_chroot.sh (right):

http://codereview.chromium.org/548083/diff/1/5#newcode32
src/scripts/make_chroot.sh:32: DEFINE_string sources "" \
Why do you want to add the sources flag? Is there a use case that you have in
mind already? I suggest we add it when we need it.

Btw- for build_image.sh I do plan on having something like this but I was going
to drop the mirror and suite and change to FLAG_sources as a comma separated
list of the format:

--sources="http://foo/bar karmic main,http://blah/blah main
restricted,file:///blah/blah"

Perhaps that is simpler?

http://codereview.chromium.org/548083/diff/1/5#newcode137
src/scripts/make_chroot.sh:137: 
None of our other shell script adds extra blank lines like you do here. Do you
mind getting rid of them?

http://codereview.chromium.org/548083/diff/1/5#newcode144
src/scripts/make_chroot.sh:144: while read LINE ; do
Why do you need a while loop here? If the input is a file can't you just append
it the file in $FLAGS_chroot?

http://codereview.chromium.org/548083/diff/1/5#newcode150
src/scripts/make_chroot.sh:150: # use file-based repo if it exists
I'm not sure if it is worth it to try and re-use people's existing local repos
given that it keeps this more complicated.

Ideally we move to a mode where people only have to create a chroot once and
then we can keep it updated via a separate script. The local repo for dev in
that case becomes much less useful.

[tedbo, 2010-01-20 19:05:39]

LGTM

Thanks! I'm very happy to see the deletions and how this has been simplified.

[tedbo, 2010-01-20 21:04:30]

LGTM

Good catch on make_local_repo.sh affecting the buildbots.