Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Unified Diff: chrome/common/platform_util_linux.cc

Issue 548071: Linux: Don't propagate $GNOME_DISABLE_CRASH_DIALOG to external apps.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 10 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/platform_util_linux.cc
===================================================================
--- chrome/common/platform_util_linux.cc (revision 36532)
+++ chrome/common/platform_util_linux.cc (working copy)
@@ -28,6 +28,15 @@
// bring up a new terminal if necessary. See "man mailcap".
env.push_back(std::make_pair("MM_NOTTTY", "1"));
+ // In Google Chrome, we do not let GNOME's bug-buddy intercept our crashes.
+ // However, we do not want this environment variable to propagate to external
+ // applications. See http://crbug.com/24120
+ char* disable_gnome_bug_buddy = getenv("GNOME_DISABLE_CRASH_DIALOG");
+ if (disable_gnome_bug_buddy &&
+ disable_gnome_bug_buddy == std::string("SET_BY_GOOGLE_CHROME")) {
+ env.push_back(std::make_pair("GNOME_DISABLE_CRASH_DIALOG", ""));
+ }
+
base::file_handle_mapping_vector no_files;
base::ProcessHandle handle;
if (base::LaunchApp(argv, env, no_files, false, &handle))
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698