Fix a problem when compiling built-ins with the top-level compiler....

Fix a problem when compiling built-ins with the top-level compiler.

Replace runtime call to NumberAdd with call to binary op stub.

Until now the top-level compiler always called a runtime function
for count operations. 

In some places we expected in the JS builtins smis as arguments.
If we perform a count operation before all smis would get converted into
heap numbers by the runtime number add function and result in a runtime 
assert.

Also: Add missing debugger information in the top-level compiler for 
do-while loops.



Committed: http://code.google.com/p/v8/source/detail?r=3610

[fschneider, 2010-01-14 16:11:44]

Uploaded a new version:
+ fix of a missing debugger information.

[Kevin Millikin (Chromium), 2010-01-14 16:57:25]

LGTM.

http://codereview.chromium.org/548029/diff/4001/4002
File src/ia32/fast-codegen-ia32.cc (right):

http://codereview.chromium.org/548029/diff/4001/4002#newcode1399
src/ia32/fast-codegen-ia32.cc:1399: GenericBinaryOpStub stub(expr->op() ==
Token::INC ? Token::ADD : Token::SUB,
The Assignment class has a function binary_op that returns the binary op that
corresponds to a compound assignment op.  It might be useful to put this one in
CountOperation:

Token::Value binary_op() {
  return op_ == Token::INC ? Token::ADD : Token::SUB;
}

[fschneider, 2010-01-14 17:22:30]

http://codereview.chromium.org/548029/diff/4001/4002
File src/ia32/fast-codegen-ia32.cc (right):

http://codereview.chromium.org/548029/diff/4001/4002#newcode1399
src/ia32/fast-codegen-ia32.cc:1399: GenericBinaryOpStub stub(expr->op() ==
Token::INC ? Token::ADD : Token::SUB,
On 2010/01/14 16:57:25, Kevin Millikin wrote:
> The Assignment class has a function binary_op that returns the binary op that
> corresponds to a compound assignment op.  It might be useful to put this one
in
> CountOperation:
> 
> Token::Value binary_op() {
>   return op_ == Token::INC ? Token::ADD : Token::SUB;
> }

Done.