Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 5473001: [cros] Use same textfield settings across existing/new user pods and screen lock. (Closed)

Created:
10 years ago by Nikita (slow)
Modified:
9 years, 7 months ago
Reviewers:
whywhat, altimofeev
CC:
chromium-reviews, nkostylev+cc_chromium.org, davemoore+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

[cros] Use same textfield settings across existing/new user pods and screen lock. BUG=chromium-os:9811 TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67899

Patch Set 1 #

Total comments: 3

Patch Set 2 : proper fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M chrome/browser/chromeos/login/existing_user_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/new_user_view.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/textfield_with_margin.h View 1 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/textfield_with_margin.cc View 1 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Nikita (slow)
10 years ago (2010-12-01 16:18:08 UTC) #1
Nikita (slow)
10 years ago (2010-12-01 18:09:37 UTC) #2
whywhat
LGTM
10 years ago (2010-12-01 18:14:27 UTC) #3
altimofeev
http://codereview.chromium.org/5473001/diff/1/chrome/browser/chromeos/login/textfield_with_margin.cc File chrome/browser/chromeos/login/textfield_with_margin.cc (right): http://codereview.chromium.org/5473001/diff/1/chrome/browser/chromeos/login/textfield_with_margin.cc#newcode36 chrome/browser/chromeos/login/textfield_with_margin.cc:36: CorrectTextfieldFontSize(this); Why correction is done here? AFAIK textfield updates ...
10 years ago (2010-12-01 18:21:35 UTC) #4
whywhat
http://codereview.chromium.org/5473001/diff/1/chrome/browser/chromeos/login/textfield_with_margin.cc File chrome/browser/chromeos/login/textfield_with_margin.cc (right): http://codereview.chromium.org/5473001/diff/1/chrome/browser/chromeos/login/textfield_with_margin.cc#newcode36 chrome/browser/chromeos/login/textfield_with_margin.cc:36: CorrectTextfieldFontSize(this); On 2010/12/01 18:21:36, altimofeev wrote: > Why correction ...
10 years ago (2010-12-01 18:27:47 UTC) #5
Nikita (slow)
http://codereview.chromium.org/5473001/diff/1/chrome/browser/chromeos/login/textfield_with_margin.cc File chrome/browser/chromeos/login/textfield_with_margin.cc (right): http://codereview.chromium.org/5473001/diff/1/chrome/browser/chromeos/login/textfield_with_margin.cc#newcode36 chrome/browser/chromeos/login/textfield_with_margin.cc:36: CorrectTextfieldFontSize(this); On 2010/12/01 18:21:36, altimofeev wrote: > Why correction ...
10 years ago (2010-12-01 18:29:16 UTC) #6
Nikita (slow)
Now with proper fix in ctor.
10 years ago (2010-12-01 18:34:26 UTC) #7
altimofeev
10 years ago (2010-12-01 18:42:14 UTC) #8 
Thanks!
LGTM

Powered by Google App Engine
This is Rietveld 408576698