Issue 5472001: Fix SSLUITest.TestUnsafeContentsInWorker*.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5472001: Fix SSLUITest.TestUnsafeContentsInWorker*. (Closed)

Created:
10 years ago by cbentzel

Modified:
9 years, 7 months ago

Reviewers:
Jay Civelli, Paweł Hajdan Jr.

CC:
scherkus (not reviewing), chromium-reviews, Paweł Hajdan Jr., ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fix SSLUITest.TestUnsafeContentsInWorker*. These still expected fixed port testserver's, but were undetected as failing since marked FLAKY. BUG=64785 TEST=browser_tests --gtest_filter="*TestUnsafeContentsInWorker*" Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67864

Patch Set 1 #

Patch Set 2 : Formatting and extraneous comment. #

Patch Set 3 : Remove extra if #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -4 lines)			Patch
M	chrome/browser/ssl/ssl_browser_tests.cc	View	1 2	3 chunks	+35 lines, -2 lines	0 comments	Download
M	chrome/test/data/ssl/page_with_unsafe_worker.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/data/ssl/unsafe_worker.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

cbentzel

Thanks to scherkus for tracking down this failure - I hadn't noticed it since the ...

10 years ago (2010-12-01 16:17:04 UTC) #1

LGTM

Expand Messages | Collapse Messages