Issue 5471002: Move app_modal_dialog stuff to ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5471002: Move app_modal_dialog stuff to ui/ (Closed)

Created:
10 years ago by Ben Goodger (Google)

Modified:
9 years, 6 months ago

Reviewers:
brettw

CC:
chromium-reviews, ben+cc_chromium.org, Erik does not do reviews, brettw-cc_chromium.org, Aaron Boodman, pam+watch_chromium.org, Paweł Hajdan Jr., davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Move app_modal_dialog stuff to ui/ BUG=none TEST=none TBR=brettw Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67894

Patch Set 1 #

Patch Set 2 : '' #

Created: 10 years ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+62 lines, -789 lines)			Patch
chrome/browser/app_modal_dialog.h	View	1	1 chunk	+0 lines, -82 lines	0 comments	Download
chrome/browser/app_modal_dialog.cc	View	1	1 chunk	+0 lines, -53 lines	0 comments	Download
chrome/browser/app_modal_dialog_queue.h	View	1	1 chunk	+0 lines, -85 lines	0 comments	Download
chrome/browser/app_modal_dialog_queue.cc	View	1	1 chunk	+0 lines, -64 lines	0 comments	Download
chrome/browser/automation/automation_provider.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
chrome/browser/automation/testing_automation_provider.cc	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
chrome/browser/browser_browsertest.cc	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
chrome/browser/chromeos/tab_closeable_state_watcher_browsertest.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
chrome/browser/extensions/alert_apitest.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
chrome/browser/extensions/extension_host.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
chrome/browser/extensions/extension_host.cc	View	1	2 chunks	+1 line, -1 line	0 comments	Download
chrome/browser/gtk/browser_window_gtk.cc	View	1	2 chunks	+1 line, -1 line	0 comments	Download
chrome/browser/gtk/js_modal_dialog_gtk.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
chrome/browser/gtk/js_modal_dialog_gtk.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
chrome/browser/js_modal_dialog.h	View	1	1 chunk	+0 lines, -117 lines	0 comments	Download
chrome/browser/js_modal_dialog.cc	View	1	1 chunk	+0 lines, -155 lines	0 comments	Download
chrome/browser/message_box_handler.h	View	1	1 chunk	+0 lines, -41 lines	0 comments	Download
chrome/browser/message_box_handler.cc	View	1	1 chunk	+0 lines, -89 lines	0 comments	Download
chrome/browser/native_app_modal_dialog.h	View	1	1 chunk	+0 lines, -39 lines	0 comments	Download
chrome/browser/tab_contents/background_contents.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
chrome/browser/tab_contents/tab_contents.h	View	1	2 chunks	+1 line, -1 line	0 comments	Download
chrome/browser/tab_contents/tab_contents.cc	View	1	2 chunks	+1 line, -1 line	0 comments	Download
chrome/browser/ui/app_modal_dialogs/app_modal_dialog.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
chrome/browser/ui/app_modal_dialogs/app_modal_dialog.cc	View		1 chunk	+4 lines, -4 lines	0 comments	Download
chrome/browser/ui/app_modal_dialogs/app_modal_dialog_queue.h	View		2 chunks	+5 lines, -5 lines	0 comments	Download
chrome/browser/ui/app_modal_dialogs/app_modal_dialog_queue.cc	View		1 chunk	+1 line, -3 lines	0 comments	Download
chrome/browser/ui/app_modal_dialogs/js_modal_dialog.h	View		2 chunks	+4 lines, -4 lines	0 comments	Download
chrome/browser/ui/app_modal_dialogs/js_modal_dialog.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
chrome/browser/ui/app_modal_dialogs/message_box_handler.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
chrome/browser/ui/app_modal_dialogs/message_box_handler.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
chrome/browser/ui/app_modal_dialogs/native_app_modal_dialog.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
chrome/browser/ui/cocoa/js_modal_dialog_cocoa.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
chrome/browser/ui/cocoa/js_modal_dialog_cocoa.mm	View	1	1 chunk	+1 line, -1 line	0 comments	Download
chrome/browser/ui/views/frame/browser_view.cc	View	1	2 chunks	+1 line, -1 line	0 comments	Download
chrome/browser/ui/views/js_modal_dialog_views.h	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
chrome/browser/ui/views/js_modal_dialog_views.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
chrome/chrome_browser.gypi	View	1	5 chunks	+9 lines, -9 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Stubber Ramp LGTM

Expand Messages | Collapse Messages