Fix MinGW build

src/platform-win32.cc

 // Copyright 2006-2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 188 matching lines @@
   return _vsnprintf(buffer, sizeOfBuffer, format, argptr);
 }
 #define _TRUNCATE 0
 
 
 int strncpy_s(char* strDest, size_t numberOfElements,
               const char* strSource, size_t count) {
   strncpy(strDest, strSource, count);
   return 0;
 }
 

[Erik Corry, 2010/12/01 22:10:18]

Extra blank line needed here (2 blank lines between functions).

+inline void MemoryBarrier() {
+  long barrier = 0;
+  __asm__ __volatile__("xchgl %%eax,%0 ":"=r" (barrier));
+}
+
 #endif  // __MINGW32__
 
 // Generate a pseudo-random number in the range 0-2^31-1. Usually
 // defined in stdlib.h. Missing in both Microsoft Visual Studio C++ and MinGW.
 int random() {
   return rand();
 }
 
 
 namespace v8 {
@@ skipping 631 matching lines @@
 #ifdef V8_HOST_ARCH_64_BIT
   static const intptr_t kAllocationRandomAddressMin = 0x0000000080000000;
   static const intptr_t kAllocationRandomAddressMax = 0x000003FFFFFF0000;
 #else
   static const intptr_t kAllocationRandomAddressMin = 0x04000000;
   static const intptr_t kAllocationRandomAddressMax = 0x3FFF0000;
 #endif
 
   // VirtualAlloc rounds allocated size to page size automatically.
   size_t msize = RoundUp(requested, static_cast<int>(GetPageSize()));
-  intptr_t address = NULL;
+  intptr_t address = (intptr_t)NULL;

[Erik Corry, 2010/12/01 22:10:18]

We don't allow C-style casts in V8.  See the Google C++ Style Guide.  I think
just putting 0 in here would be OK.

 
   // Windows XP SP2 allows Data Excution Prevention (DEP).
   int prot = is_executable ? PAGE_EXECUTE_READWRITE : PAGE_READWRITE;
 
   // For exectutable pages try and randomize the allocation address
-  if (prot == PAGE_EXECUTE_READWRITE && msize >= Page::kPageSize) {
+  if (prot == PAGE_EXECUTE_READWRITE && msize >= (size_t)Page::kPageSize) {

[Erik Corry, 2010/12/01 22:10:18]

C-style cast

     address = (V8::RandomPrivate() << kPageSizeBits)
       | kAllocationRandomAddressMin;
     address &= kAllocationRandomAddressMax;
   }
 
   LPVOID mbase = VirtualAlloc(reinterpret_cast<void *>(address),
                               msize,
                               MEM_COMMIT | MEM_RESERVE,
                               prot);
-  if (mbase == NULL && address != NULL)
+  if (mbase == NULL && address != (intptr_t)NULL)

[Erik Corry, 2010/12/01 22:10:18]

C-style cast

     mbase = VirtualAlloc(NULL, msize, MEM_COMMIT | MEM_RESERVE, prot);
 
   if (mbase == NULL) {
     LOG(StringEvent("OS::Allocate", "VirtualAlloc failed"));
     return NULL;
   }
 
   ASSERT(IsAligned(reinterpret_cast<size_t>(mbase), OS::AllocateAlignment()));
 
   *allocated = msize;
@@ skipping 452 matching lines @@
 
   // Return the number of frames filled in.
   return frames_count;
 }
 
 // Restore warnings to previous settings.
 #pragma warning(pop)
 
 #else  // __MINGW32__
 void OS::LogSharedLibraryAddresses() { }
+void OS::SignalCodeMovingGC() { }
 int OS::StackWalk(Vector<OS::StackFrame> frames) { return 0; }
 #endif  // __MINGW32__
 
 
 uint64_t OS::CpuFeaturesImpliedByPlatform() {
   return 0;  // Windows runs on anything.
 }
 
 
 double OS::nan_value() {
@@ skipping 594 matching lines @@
 
   // Release the thread handles
   CloseHandle(data_->sampler_thread_);
   CloseHandle(data_->profiled_thread_);
 }
 
 
 #endif  // ENABLE_LOGGING_AND_PROFILING
 
 } }  // namespace v8::internal