Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 5471001: Fix MinGW build (Closed)

Created:
10 years ago by piscisaureus
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix MinGW build - add missing functions SignalCodeMovingGC() and MemoryBarrier() - avoid pointer conversion/comparison warnings - don't attempt to hide symbols with -fvisibility, MinGW doesn't support it BUG=http://code.google.com/p/v8/issues/detail?id=949 Committed: http://code.google.com/p/v8/source/detail?r=5913

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address Erik�s comments #

Patch Set 3 : Lint hates me #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -5 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M SConstruct View 2 chunks +11 lines, -2 lines 0 comments Download
M src/platform-win32.cc View 1 2 4 chunks +11 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Erik Corry
Thanks for the patch. There are a few cosmetic issues, see below. http://codereview.chromium.org/5471001/diff/1/src/platform-win32.cc File src/platform-win32.cc ...
10 years ago (2010-12-01 22:10:18 UTC) #1
piscisaureus
You were right. I did that. Also changed a 'long' type to int; lint complained ...
10 years ago (2010-12-01 22:50:46 UTC) #2
Søren Thygesen Gjesse
10 years ago (2010-12-02 15:39:37 UTC) #3
On 2010/12/01 22:50:46, bertbelder wrote:
> You were right. I did that.
> Also changed a 'long' type to int; lint complained about it and on ia32
there's
> no difference anyway.

Committed: http://code.google.com/p/v8/source/detail?r=5913

Thank you for the patch. Closing issue.

Powered by Google App Engine
This is Rietveld 408576698