Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Unified Diff: src/scripts/run_remote_tests.sh

Issue 547018: Add functionality required for perf dashboard. (Closed)
Patch Set: Reuse start timestamp already established Created 10 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/scripts/image_to_live.sh ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/scripts/run_remote_tests.sh
diff --git a/src/scripts/run_remote_tests.sh b/src/scripts/run_remote_tests.sh
index 62e873b407244f375656106837d12f691899f3ea..da3919192213af47bd9be000d056d6587b52938b 100755
--- a/src/scripts/run_remote_tests.sh
+++ b/src/scripts/run_remote_tests.sh
@@ -20,6 +20,7 @@ DEFINE_string output_file "${DEFAULT_OUTPUT_FILE}" "Test run output" o
DEFINE_boolean verbose ${FLAGS_FALSE} "Show verbose autoserv output" v
DEFINE_boolean update_db ${FLAGS_FALSE} "Put results in autotest database" u
DEFINE_string machine_desc "" "Machine description used in database"
+DEFINE_string build_desc "" "Build description used in database"
function cleanup() {
if [[ $FLAGS_cleanup -eq ${FLAGS_TRUE} ]]; then
@@ -57,6 +58,26 @@ function remove_quotes() {
echo "$1" | sed -e "s/^'//; s/'$//"
}
+# Adds attributes to all tests run
+# Arguments:
+# $1 - results directory
+# $2 - attribute name (key)
+# $3 - attribute value (value)
+function add_test_attribute() {
+ local results_dir="$1"
+ local attribute_name="$2"
+ local attribute_value="$3"
+ if [[ -z "$attribute_value" ]]; then
+ return;
+ fi
+
+ for status_file in $(echo "${results_dir}"/*/status); do
+ local keyval_file=$(dirname $status_file)/keyval
+ echo "Updating ${keyval_file}"
+ echo "${attribute_name}=${attribute_value}" >> "${keyval_file}"
+ done
+}
+
function main() {
assert_outside_chroot
@@ -138,8 +159,8 @@ function main() {
fi
echo "Running ${type} test ${control_file}"
local short_name=$(basename $(dirname "${control_file}"))
- local timestamp=$(date '+%s')
- local results_dir="${TMP}/${short_name},${FLAGS_machine_desc},${timestamp}"
+ local start_time=$(date '+%s')
+ local results_dir="${TMP}/${short_name},${FLAGS_machine_desc},${start_time}"
rm -rf "${results_dir}"
local verbose=""
if [[ ${FLAGS_verbose} -eq $FLAGS_TRUE ]]; then
@@ -162,9 +183,14 @@ function main() {
# Leave around output directory if the test failed.
FLAGS_cleanup=${FLAGS_FALSE}
fi
+ local end_time=$(date '+%s')
# Update the database with results.
if [[ ${FLAGS_update_db} -eq ${FLAGS_TRUE} ]]; then
+ add_test_attribute "${results_dir}" machine-desc "${FLAGS_machine_desc}"
+ add_test_attribute "${results_dir}" build-desc "${FLAGS_build_desc}"
+ add_test_attribute "${results_dir}" server-start-time "${start_time}"
+ add_test_attribute "${results_dir}" server-end-time "${end_time}"
if ! "${parse_cmd}" -o "${results_dir}"; then
echo "Parse failed." | tee -a "${FLAGS_output_file}"
FLAGS_cleanup=${FLAGS_FALSE}
« no previous file with comments | « src/scripts/image_to_live.sh ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698