Add functionality required for perf dashboard.

Add functionality required for perf dashboard.

image_to_live.sh - fix problem where errorvalue is non-zero even when
  reimage was successful.
run_remote_tests.sh - add ability to stow build description in the
  autotest database so we can track the exact build for which
  tests succeed/fail.

[sosa, 2010-01-12 04:05:40]

LGTM ... only a nit/question about explicit exit 0. Do you only return 0 just so
you can ignore errors in parent scripts?

http://codereview.chromium.org/547018/diff/1/2
File src/scripts/image_to_live.sh (right):

http://codereview.chromium.org/547018/diff/1/2#newcode197
src/scripts/image_to_live.sh:197: exit 0
Why does this need to be explicit?  What's wrong with returning what main
returns?

[sosa, 2010-01-13 00:31:03]

http://codereview.chromium.org/547018/diff/3002/7002
File src/scripts/run_remote_tests.sh (right):

http://codereview.chromium.org/547018/diff/3002/7002#newcode74
src/scripts/run_remote_tests.sh:74: for status_file in $(echo
"${results_dir}"/*/status); do
Why the rename?  You don't use status_file anywhere

http://codereview.chromium.org/547018/diff/3002/7002#newcode194
src/scripts/run_remote_tests.sh:194: add_test_attribute "${results_dir}"
server-end-time "${start_time}"
I believe you meant end_time here

[kmixter1, 2010-01-13 02:06:49]

http://codereview.chromium.org/547018/diff/1/2
File src/scripts/image_to_live.sh (right):

http://codereview.chromium.org/547018/diff/1/2#newcode197
src/scripts/image_to_live.sh:197: exit 0
It's unnecessary and now removed.
On 2010/01/12 04:05:41, sosa wrote:
> Why does this need to be explicit?  What's wrong with returning what main
> returns?

http://codereview.chromium.org/547018/diff/3002/7002
File src/scripts/run_remote_tests.sh (right):

http://codereview.chromium.org/547018/diff/3002/7002#newcode74
src/scripts/run_remote_tests.sh:74: for status_file in $(echo
"${results_dir}"/*/status); do
On 2010/01/13 00:31:04, sosa wrote:
> Why the rename?  You don't use status_file anywhere

I do, the next line.

http://codereview.chromium.org/547018/diff/3002/7002#newcode194
src/scripts/run_remote_tests.sh:194: add_test_attribute "${results_dir}"
server-end-time "${start_time}"
Good catch!
On 2010/01/13 00:31:04, sosa wrote:
> I believe you meant end_time here

[sosa, 2010-01-13 02:10:10]

http://codereview.chromium.org/547018/diff/3002/7002
File src/scripts/run_remote_tests.sh (right):

http://codereview.chromium.org/547018/diff/3002/7002#newcode74
src/scripts/run_remote_tests.sh:74: for status_file in $(echo
"${results_dir}"/*/status); do
I meant why the rename and only use it once (you never actually use the status
file

On 2010/01/13 02:06:49, kmixter1 wrote:
> On 2010/01/13 00:31:04, sosa wrote:
> > Why the rename?  You don't use status_file anywhere
> 
> I do, the next line.

[kmixter1, 2010-01-13 02:14:00]

http://codereview.chromium.org/547018/diff/3002/7002
File src/scripts/run_remote_tests.sh (right):

http://codereview.chromium.org/547018/diff/3002/7002#newcode74
src/scripts/run_remote_tests.sh:74: for status_file in $(echo
"${results_dir}"/*/status); do
Ah, only tests which generate performance data output will have a keyval file. 
So the code was previously only storing the test annotations I wanted for those
tests which also generated performance data.  Every test generates a status_file
so this is a better way to find the directories.

On 2010/01/13 02:10:10, sosa wrote:
> I meant why the rename and only use it once (you never actually use the status
> file
> 
> On 2010/01/13 02:06:49, kmixter1 wrote:
> > On 2010/01/13 00:31:04, sosa wrote:
> > > Why the rename?  You don't use status_file anywhere
> > 
> > I do, the next line.
> 
>