Issue 5464001: Change RegExp syntax to fail on invalid ranges like [\d-x], [x-\d] and [\d-\d].

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5464001: Change RegExp syntax to fail on invalid ranges like [\d-x], [x-\d] and [\d-\d]. (Closed)

Created:
10 years ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Erik Corry, antonm

CC:
v8-dev

Visibility:
Public.

Description

Change RegExp syntax to fail on invalid ranges like [\d-x], [x-\d] and [\d-\d]. The previous behavior was to treat the "-" as verbatim if the range was invalid. This change matches the JSC changeset http://trac.webkit.org/changeset/72813/

Patch Set 1 #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+79 lines, -56 lines)			Patch
M	src/parser.cc	View	3 chunks	+18 lines, -4 lines	0 comments	Download
M	test/cctest/test-regexp.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	test/mjsunit/regexp.js	View	2 chunks	+44 lines, -38 lines	0 comments	Download
M	test/mjsunit/third_party/regexp-pcre.js	View	5 chunks	+13 lines, -11 lines	0 comments	Download
M	test/mozilla/mozilla.status	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm and tnx

Expand Messages | Collapse Messages