Figure out error in test PrepopulateRespectBlank....

Figure out error in test PrepopulateRespectBlank.

Revert previous traces and add one targeted test.

My traces seem to indicate that something else
than a Chrome window has focus when the test fails.

Lets figure out what that is...

BUG=62937
TEST=Tracking down problem in test


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67849

[Paweł Hajdan Jr., 2010-12-01 14:13:25]

Test changes LGTM. Could you find someone to look at the Windows-specific code?
I'm not really familiar with it (things like whether we need to close an HWND
etc).

[Finnur, 2010-12-01 14:17:14]

Sure!

M-A, can you take a look at the function at the top of
find_bar_host_interactive_uitest.cc?

[M-A Ruel, 2010-12-01 14:22:34]

http://codereview.chromium.org/5463001/diff/1/chrome/browser/automation/ui_co...
File chrome/browser/automation/ui_controls_win.cc (right):

http://codereview.chromium.org/5463001/diff/1/chrome/browser/automation/ui_co...
chrome/browser/automation/ui_controls_win.cc:77: if (l_param & (1 << 30))  //
Only send on key up.
style nit: Ugh, I hate comments positioned like this, especially without
bracket.

http://codereview.chromium.org/5463001/diff/1/chrome/browser/ui/views/find_ba...
File chrome/browser/ui/views/find_bar_host_interactive_uitest.cc (right):

http://codereview.chromium.org/5463001/diff/1/chrome/browser/ui/views/find_ba...
chrome/browser/ui/views/find_bar_host_interactive_uitest.cc:61:
::GetWindowTextA(window, WriteInto(&caption, len), len);
? Why not GetWindowText with a std::wstring?

http://codereview.chromium.org/5463001/diff/1/chrome/browser/ui/views/find_ba...
chrome/browser/ui/views/find_bar_host_interactive_uitest.cc:67: HANDLE process =
::OpenProcess(PROCESS_QUERY_LIMITED_INFORMATION,
OpenProcessHandle() in base/process_util.h

http://codereview.chromium.org/5463001/diff/1/chrome/browser/ui/views/find_ba...
chrome/browser/ui/views/find_bar_host_interactive_uitest.cc:72: if
(!GetProcessImageFileNameA(process, WriteInto(&filename, len), len)) {
Why ansi?

[Finnur, 2010-12-01 14:40:35]

http://codereview.chromium.org/5463001/diff/1/chrome/browser/automation/ui_co...
File chrome/browser/automation/ui_controls_win.cc (right):

http://codereview.chromium.org/5463001/diff/1/chrome/browser/automation/ui_co...
chrome/browser/automation/ui_controls_win.cc:77: if (l_param & (1 << 30))  //
Only send on key up.
This is the way I arrived at it before adding traces. But, I've changed it now.

On 2010/12/01 14:22:35, Marc-Antoine Ruel wrote:
> style nit: Ugh, I hate comments positioned like this, especially without
> bracket.

http://codereview.chromium.org/5463001/diff/1/chrome/browser/ui/views/find_ba...
File chrome/browser/ui/views/find_bar_host_interactive_uitest.cc (right):

http://codereview.chromium.org/5463001/diff/1/chrome/browser/ui/views/find_ba...
chrome/browser/ui/views/find_bar_host_interactive_uitest.cc:72: if
(!GetProcessImageFileNameA(process, WriteInto(&filename, len), len)) {
No good reason. Changed. 

On 2010/12/01 14:22:35, Marc-Antoine Ruel wrote:
> Why ansi?

[M-A Ruel, 2010-12-01 14:51:12]

lgtm with one nit

http://codereview.chromium.org/5463001/diff/14001/chrome/browser/ui/views/fin...
File chrome/browser/ui/views/find_bar_host_interactive_uitest.cc (right):

http://codereview.chromium.org/5463001/diff/14001/chrome/browser/ui/views/fin...
chrome/browser/ui/views/find_bar_host_interactive_uitest.cc:76: filename =
std::wstring(L"Unable to read filename (error ") +
The 'std::wstring(' part is not strictly necessary. You're creating another
temporary object.