Issue 546129: Fix stack overflow in cctest/test-api/Threadin2 after r3613.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 546129: Fix stack overflow in cctest/test-api/Threadin2 after r3613. (Closed)

Created:
10 years, 11 months ago by Vitaly Repeshko

Modified:
9 years, 7 months ago

Reviewers:
antonm

CC:
v8-dev

Visibility:
Public.

Description

Fix stack overflow in cctest/test-api/Threadin2 after r3613. r3613 started wrapping all builtins in extra call in debug mode so it became easier to cause stack overflow especially in 64-bit build. Committed: http://code.google.com/p/v8/source/detail?r=3749

Patch Set 1 #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	test/cctest/test-api.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

antonm

10 years, 11 months ago (2010-01-25 19:34:36 UTC) #2

lgtm and thanks.

One thing you might want to consider is platform-specific  to keep this
desirable property of near maximum.

Expand Messages | Collapse Messages